C# - Nested Loop

Question

I'm doing a simple c# exercise. The problem is I want to show output such as:

Output

Sample 1 => a

Sample 2 => b

Sample 1 => c

Sample 2 => d

Sample 1 => e

Sample 2 => f

Here's input 1 :

Sample 1 => 
Sample 2 =>

Here's input 2 :

a
b
c
d
e
f

Here's my code

foreach (string input1 in RichTextBox1.Lines)
{
    foreach (string input2 in RichTextBox2.Lines)
    {
        RichTextBox3.Text += input1 + input2 + Environment.NewLine;
    }
}

But it doe's not work .can anyone help me. thank you..

I don't think you need a nested-loops, maybe a int to flip remember the position of input1 is fine — Prisoner
– Prisoner, Commented Sep 19, 2016 at 4:47
"it doe's not work" is a uselessly unspecific problem description, especially given the lack of a good minimal reproducible example that reliably reproduces whatever problem you have. — Peter Duniho
– Peter Duniho, Commented Sep 19, 2016 at 4:47

Keyur PATEL · Accepted Answer · 2016-09-19 04:51:55Z

3

You can try using modulo (%), and use RichTextBox2.Lines as the outer loop.

for (int i=0; i<RichTextBox2.Lines.Length; i++)
{
    var length = RichTextBox1.Lines.Length;
    RichTextBox3.Text += RichTextBox1.Lines[(i%length)] + RichTextBox2.Lines[i] + Environment.NewLine;
}

Looks complicated, but modulo gives you what you want even if there is a Sample 3, Sample 4, and so on.

answered Sep 19, 2016 at 4:51

Keyur PATEL

2,3271 gold badge18 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Salah Akbari · Accepted Answer · 2016-09-19 09:27:45Z

3

You need to corresponding elements of two sequences. So you can use LINQ's Zip method easily to achieve this result like this (Also by using String.Join method we didn't use any loop.):

richTextBox3.Text = String.Join(Environment.NewLine, 
                    Enumerable.Repeat(richTextBox1.Lines, richTextBox2.Lines.Count())
                    .SelectMany(c => c).Zip(richTextBox2.Lines, (f, s) => f + " => " + s));

edited Sep 19, 2016 at 9:27

answered Sep 19, 2016 at 4:48

Salah Akbari

40k10 gold badges85 silver badges115 bronze badges

Comments

sachin · Accepted Answer · 2016-09-19 04:51:46Z

1

Here is the code that would give you the expected output:

int i = 0;
foreach (var input2 in RichTextBox2.Lines)
{
    string input1 = RichTextBox1.Lines[i % RichTextBox1.Lines.Length];
    RichTextBox3.Text += input1 + input2 + Environment.NewLine;
    i++;
}

answered Sep 19, 2016 at 4:51

sachin

2,36114 silver badges24 bronze badges

Comments

GhostCat · Accepted Answer · 2016-09-19 04:47:05Z

0

Your problem is that your are looping your second input ... for each first input! Again, and again, and again.

So: you only need one loop here. Here is some pseudo code to get started:

... first check that both line counts are equal
for (int i=0; i<linecount; i++) {
    RichTextBox3.Text += input1[i] + input2[i] + Environment.NewLine
}

Where input1[i] basically translates to: you have to push the content of your two initial boxes into an array for example.

answered Sep 19, 2016 at 4:47

GhostCat

141k28 gold badges190 silver badges262 bronze badges

Collectives™ on Stack Overflow

C# - Nested Loop

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related