How to open terminal editor from within `commit-msg` git hook

Question

I have a commit-msg hook that validates the contents of the commit message.

If that check fails I want to re-open the commit message file my terminal editor so that I can correct the mistake.

I have the following, which prompts the user when the validation fails.

#!/usr/bin/env bash

COMMIT_MSG_FILE="$1"

# If we have a STDIN, use it, otherwise get one
if tty >/dev/null 2>&1; then
  TTY=$(tty)
else
  TTY=/dev/tty
fi

while true; do

  # read lines from file
  COMMIT_MSG_LINES=()
  while IFS= read -r; do
    COMMIT_MSG_LINES+=("$REPLY")
  done < <(cat $COMMIT_MSG_FILE)

  # validate - limit the subject to 50 characters
  test "${#COMMIT_MSG_LINES[0]}" -le 50 && break;

  echo -n "Validation failed. Proceed with commit [y/n]? "
  read REPLY < "$TTY"

  case "$REPLY" in
    Y*|y*) exit 0 ;;
    N*|n*) exit 1 ;;
    *)     $EDITOR $COMMIT_MSG_FILE; continue ;;
  esac

done

Any response other than YyNn should re-open the editor.

However instead, I'm getting the following error:

Received SIGHUP or SIGTERM

When I call the hook manually the script works correctly, so I assume this is something to do with the context in which the hooks are invoked.

How can I get the editor to open from within a commit-msg hook like this?

tommarshall · Accepted Answer · 2016-08-19 16:47:42Z

1

Solved it. Explicitly redirecting the TTY to $EDITOR appears to work.

Replaced:

$EDITOR $COMMIT_MSG_FILE

with:

$EDITOR $COMMIT_MSG_FILE < "$TTY"

answered Aug 19, 2016 at 16:47

tommarshall

2,1685 gold badges24 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to open terminal editor from within `commit-msg` git hook

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related