Circular dependency angularjs

Question

can anyone tell me where is the circular dependency in the following code?

var homeApp = angular.module("homeApp",['ngAnimate', 'ui.bootstrap']);

'use strict';

homeApp.factory('AdminDashboardService', ['$http', '$q', function($http, $q){


    return {


        'response': function(response) {
              // do something on success
              console.log("Yes Command comes here");
              return response;
            },

        getAllHolidays: function(monthYearArrayForHolidayList) {
            console.log("For full list of holidays list length: "+monthYearArrayForHolidayList.length);
            var isMonthly="no";
            return $http.get('/tasktrac/holiday/getHoliday/isMonthly/'+isMonthly+'/'+monthYearArrayForHolidayList)
                    .then(
                            function(response){
                                return response.data;
                            }, 
                            function(errResponse){
                                //console.error('Error while fetching holiday');
                                return $q.reject(errResponse);
                            }
                    );
    },
}]);


homeApp.config(['$httpProvider', function($httpProvider) {  
    $httpProvider.interceptors.push('AdminDashboardService');
}]);

I am stuck at this point please do me a favour in resolving this issue. This is the Error I got on the browser Please click here to see error Thank you..!!

fantarama · Accepted Answer · 2016-07-12 13:34:29Z

4

A $http interceptor could not declare $http as a dependency!

Inject $injector:

homeApp.factory('AdminDashboardService', ['$injector', '$q', function($injector, $q){


    return {


        'response': function(response) {
              // do something on success
              console.log("Yes Command comes here");
              return response;
            },

        getAllHolidays: function(monthYearArrayForHolidayList) {
            console.log("For full list of holidays list length: "+monthYearArrayForHolidayList.length);
            var isMonthly="no";
            return $injector.get("$http").get('/tasktrac/holiday/getHoliday/isMonthly/'+isMonthly+'/'+monthYearArrayForHolidayList)
                    .then(
                            function(response){
                                return response.data;
                            }, 
                            function(errResponse){
                                //console.error('Error while fetching holiday');
                                return $q.reject(errResponse);
                            }
                    );
    },
}]);

edited Jul 12, 2016 at 13:34

answered Jul 12, 2016 at 13:27

fantarama

8806 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Vish Over a year ago

Can you elaborate further, I am sorry I am new to angular js, Can you tell me what exactly I need to do, I did not understand the answer, Please suggest me changes in my code

fantarama Over a year ago

posted fixed code, no much to explain: $http injection replaced with $injector. If you are new to angular be sure to understand Dependecy Injection concepts

Vish Over a year ago

I am getting this error [$injector:unpr] errors.angularjs.org/1.5.0/$injector/…

Vish Over a year ago

Am I not supposed to add "homeApp.config(...)" ??

fantarama Over a year ago

check "$injector.get("$http")" spelling, look like missing the $ prefix

Collectives™ on Stack Overflow

Circular dependency angularjs

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related