Javascript array assinging to variable gets undefined

Question

Hello what i am trying to do is just to draw few images .so at first i made a group(i think this function is a part of a plugin i am using but thats no matter) then i made an array to store a name and src of several images and then i am calling a for loop to draw those images but the thing is i got no results at all no errors nothing so i try to alert "b.name" and "b.src" but result i got is undefined could someone explain me where is a problem cuz for me its seems everything good

            var mapGroup = new Group();
            var mapVillage = [
                {name: "leaf", src: "js/leaf.png"},
                {name: "sand", src: "js/sand.png"},
                {name: "stone", src: "js/stone.png"},
                {name: "cloud", src: "js/cloud.png"},
                {name: "mist", src: "js/mist.png"},
                {name: "rain", src: "js/rain.png"},
                {name: "grass", src: "js/grass.png"},
                {name: "sound", src: "js/sound.png"},
                {name: "hotwater", src: "js/hotwater.png"},
                {name: "waterfall", src: "js/waterfall.png"}
            ];

            for(var i = 0; i < mapVillage.length; i++){
                var b = mapVillage[i];
                b = new Sprite(game.width, game.height);
                b.image = game.assets[b.src];
                alert(b.name);
                mapGroup.addChild(b);
            }

You're overriding b in var b = mapVillage[i]; b = new Sprite(game.width, game.height); — Tushar
– Tushar, Commented Jul 12, 2016 at 12:07
The variable b cannot be both an entry in the mapVillage array and a new Sprite at the same time. — Pointy
– Pointy, Commented Jul 12, 2016 at 12:07
i think i was trying to assing a sprite for each array element cuz later i am going to do hittest — yahoo5000
– yahoo5000, Commented Jul 12, 2016 at 12:15

Dylan Meeus · Accepted Answer · 2016-07-12 12:08:30Z

3

Your mistake is here

   var b = mapVillage[i];
   b = new Sprite(game.width, game.height);

You are assigning b first to an entry of mapVillage, which does have the b.image you are looking for. But you are overriding it in the next line. So when you are calling b.image next, it is looking for 'image' on a "Sprite", which does not have that property ;-)

To solve it, simply assign the Sprite to a new variable. var sprite = new Sprite(game.width, game.height);

answered Jul 12, 2016 at 12:08

Dylan Meeus

5,8303 gold badges33 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

rpadovani · Accepted Answer · 2016-07-12 12:08:59Z

1

You first assign to var b an object (var b = mapVillage[i];) then override it assigning a Sprite to it. You need two variables, something like this:

for (var i = 0; i < mapVillage.length; i++){
  var b = mapVillage[i];
  var sprite = new Sprite(game.width, game.height);
  sprite.image = game.assets[b.src];
  alert(b.name);
  mapGroup.addChild(sprite);
}

answered Jul 12, 2016 at 12:08

rpadovani

7,4102 gold badges34 silver badges50 bronze badges

Collectives™ on Stack Overflow

Javascript array assinging to variable gets undefined

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related