While Loop Not Breaking In Python

Question

I have a program like this:

def read():
    while True:
        for line in temp1:
            if event in line:
                print temp1.next()
            elif date in line:
                print temp1.next()
            elif ending in line:
                print 'End of file'
                break
event = '1'
date = '2'
ending = '3'
temp1 = open('test.txt')

And test.txt looks like this:

1
ABC
2
CAB
3

The program outputs this:

ABC
CAB

And then it goes into an infinite loop. Is there a way to fix this?

Is the text file separated line by line? Or is it all one line or comma separated? Also, please post the output of the code before it runs into an infinite loop. — rb612
– rb612, Commented Jun 25, 2016 at 3:18
The break is breaking out of the for loop, not the while loop. — johmsp
– johmsp, Commented Jun 25, 2016 at 3:21
Yes it is separated line by line, The format didn't come out — Bill Wang
– Bill Wang, Commented Jun 25, 2016 at 3:21
Although while 1 is understood, while True is typically better for clarity. — Jason
– Jason, Commented Jun 25, 2016 at 3:28

Blckknght · Accepted Answer · 2016-06-25 03:22:26Z

4

Your break statement only breaks out of the for loop (if it's hit). It doesn't, and indeed, can't break out of the while loop as well. Though I'm not sure what the while loop is there for, since the for loop should iterate over the whole file. Since you're already in a function, you can use a return statement to break out of multiple loops (though it would probably be better to just get rid of the extra loop).

answered Jun 25, 2016 at 3:22

Blckknght

106k11 gold badges135 silver badges188 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

hobozero · Accepted Answer · 2016-06-25 03:39:16Z

0

Add a second break statement on the line after the first break statement, but line it up with your for statement.

answered Jun 25, 2016 at 3:39

hobozero

703 silver badges9 bronze badges

Collectives™ on Stack Overflow

While Loop Not Breaking In Python

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related