Removing Dependency From Controller Constructor in MVC

Question

I am creating a MVC application using NINject as my IOC. I am trying to separate my business logic from controller. And so I don't want my controller constructor creates for my any Dependency Object i.e. I dont want to pass my interface in the constructor and than it gets resolved through IOC container. It should be the responsibility of the business logic layer. I am trying to achieve something like below.

public BusinessHolidayController()
{

}
// GET: BusinessHoliday
public ActionResult Index(Product product)
{
    string model = invoke<IProduct>().GetSum(product);
    return View(model);
}

Well that can be the busienss logic class or may be I can write a extension method for the controller to resolve dependencies and than get the required object. — maxspan
– maxspan, Commented Jun 15, 2016 at 4:36
Can you please elaborate a bit more? What do you mean by "Dependency Object"? Most importantly, what's the question? — Leo
– Leo, Commented Jun 15, 2016 at 4:37
Are you saying you want something like a "Component Factory" that resolves all dependencies and that that "Component Factory" must reside in the "business logic"? — Leo
– Leo, Commented Jun 15, 2016 at 4:39

Win · Accepted Answer · 2016-06-15 04:45:26Z

3

What you are above to do is leaning toward Service Locator Pattern which is anti-pattern and a dangerous pattern. Its disadvantages are greater than its advantages.

There are four basic DI patterns -

Constructor Injection
Property Injection
Method Injecton
Ambient Context

For MVC controller, you want to use Constructor Injection, because it is the best pattern of the above four patterns especially for controller.

It should be the responsibility of the business logic layer.

No. Composite Root should be placed entry point of the application such as Global.asax.

For more information, you want to read Mark Seemann's Dependency Injection in .NET.

answered Jun 15, 2016 at 4:45

Win

62.4k13 gold badges106 silver badges190 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

maxspan Over a year ago

do you mean I should resolve my dependency in Global.asax or the IOC container initializer.

Collectives™ on Stack Overflow

Removing Dependency From Controller Constructor in MVC

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related