How to reduce time of execution for javascript code

Question

Below is my code which is taking time in the for loop to extract data from one object and filling another object. Is there any way to reduce the time of execution? I have tried a while loop but it is not helping that much. Kindly help

function SetGridWithData(result) {
    if (!result) {
        return;
    }
    CtrlBillableItem_SearhedBillableItems = result
    var boxOfJson = [];
    var j = 100;
    if (result.length >= 100) {
        if (PagingLastRecNum == 0) {

            btnPrevious.style.display = 'none';
            for (var i = 0; i < j; i++) {
                boxOfJson.push(result[i]);
            }
        } else {
            btnPrevious.style.display = 'inline';
            var intializer = (j * PagingLastRecNum) + PagingLastRecNum;
            var limiter = intializer + 99;
            for (var i = intializer; i < limiter; i++) {
                boxOfJson.push(result[i]);
            }
        }

    } else {
        btnPrevious.style.display = 'none';
        btnNext.style.display = 'none';

        for (var i = 0; i < result.length; i++) {
            boxOfJson.push(result[i]);
        }

    }
}

I am trying to implement paging which is done, but 100 data per page first it will check page no 0 if it is then loop one and if other than 0 than else case.

You could try slice to take a subsection of your array in one go, rather than pushing into a new array, which may involve reallocation and expansion of that array as it grows. But I doubt even that would be slow for 100 elements. — Rup
– Rup, Commented Jun 10, 2016 at 10:07
Also since you're using i < limiter not i <= limiter you probably want to add the 100 again, not 99. — Rup
– Rup, Commented Jun 10, 2016 at 10:08
sorry the last comment i haven't get can you explain me a bit more is there any mistake i mean it will fetch next 100 always right? — Tanmay
– Tanmay, Commented Jun 10, 2016 at 10:11
Go with slice, as @Rup pointed out. As a note: Preallocating arrays via new Array(length) is always faster than dynamic expanding them in a loop with known bounds. — le_m
– le_m, Commented Jun 10, 2016 at 15:20

Sandman · Accepted Answer · 2016-06-10 10:11:56Z

You could try caching result.length at the beginning of your function (following the if check at the beginning)..

   function SetGridWithData(result) {
            if (!result) { return; }
            var resultLength = result.length;
            CtrlBillableItem_SearhedBillableItems = result
            var boxOfJson = [];
            var j = 100;
            if (resultLength >= 100) {
                if (PagingLastRecNum == 0) {

                    btnPrevious.style.display = 'none';
                    for (var i = 0; i < j; i++) {
                        boxOfJson.push(result[i]);
                    }
                }
                else {
                    btnPrevious.style.display = 'inline';
                    var intializer = (j * PagingLastRecNum) + PagingLastRecNum;
                    var limiter = intializer + 99;
                    for (var i = intializer; i < limiter; i++) {
                        boxOfJson.push(result[i]);
                    }
                }

            }
            else {
                btnPrevious.style.display = 'none';
                btnNext.style.display = 'none';

                for (var i = 0; i < resultLength; i++) {
                    boxOfJson.push(result[i]);
                }

            }
}

Collectives™ on Stack Overflow

How to reduce time of execution for javascript code

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related