MySQL Insert via php is showing an error

Question

I tried to INSERT values into an sql database via php. There is no need to check "database.php" as it works. It shows

Error: unexpected '$myquery' (T_STRING).

I'm using xampp 3.2.1 as a localhost. NEED HELP FAST.THANKS!!!

 <?php 

  require 'database.php';

  $for= $_GET ["for"];
  $approved= $_GET ["approved"];
  $before= $_GET ["before"]

  $myquery="INSERT INTO request('request date', 'request for', 'approved by') VALUES (NOW(),'$for','$approved')";
  $query = mysql_query($myquery);
   ?>

Wrap off quotes from table and column name instead use backtick. — Saty
– Saty, Commented May 4, 2016 at 13:52
and sorry, I forget to tell that I closed the php tag like ?> this. — Pranav Kumar
– Pranav Kumar, Commented May 4, 2016 at 13:54
You get the error because you forgot a semicolon. Adding the semicolon however won't fix the entire script. — Daan
– Daan, Commented May 4, 2016 at 13:55
Never use raw data from the client in sql queries, otherwise you risk bobby drop tables - xkcd.com/327 — Richard
– Richard, Commented May 25, 2016 at 7:20

halfer · Accepted Answer · 2019-01-02 18:26:10Z

2

Just like Daan said, you forgot a semicolon. You'll need to make this edit:

$before = $_GET["before"];
// note the semicolon at the end of the line

Also, you should use back ticks to quote your field names like so:

$myquery = "INSERT INTO request(`request date`, `request for`, `approved by`) VALUES (NOW(),'$for','$approved')";

One final suggestion, you should move away from using the mysql_* functions to using either their mysqli_* functions or PDO.

edited Jan 2, 2019 at 18:26

halfer

20.2k20 gold badges110 silver badges207 bronze badges

answered May 4, 2016 at 14:06

Emmanuel Okeke

1,48215 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

MySQL Insert via php is showing an error

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related