WPF Listbox - data binding problem

Question

I have this problem, when I run application I see listbox with items "red", "blue", "yellow". But when I type "black" to textBox1 and press Button1 item is not added. Any idea why?

 public partial class Window1 : Window
{
    private static ArrayList myItems = new ArrayList();
    public Window1()
    {
        InitializeComponent();
    }

    private void Window_Loaded(object sender, RoutedEventArgs e)
    {
        listBox1.ItemsSource = myItems;
        myItems.Add("red");
        myItems.Add("blue");
        myItems.Add("yellow");   
    }

    private void button1_Click(object sender, RoutedEventArgs e)
    {
        myItems.Add(textBox1.Text);
    }
}

Jesper Larsen-Ledet · Accepted Answer · 2010-09-13 08:00:52Z

3

You should replace the ArrayList with an ObservableCollection<string> which will communicate to the ListBox when its contents change.

answered Sep 13, 2010 at 8:00

Jesper Larsen-Ledet

6,7334 gold badges33 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 09:57:58Z

0

This is because the view (the listbox in this case) is not informed about the change.

You should either implement INotifyProperyChanged or simply reset the itemsSource:

private void button1_Click(object sender, RoutedEventArgs e)
{
    myItems.Add(textBox1.Text);
    // refresh:
    listBox1.ItemsSource = myItems;
}

(Although using OnPropertyChanged is better practice for sure.)

edited May 23, 2017 at 9:57

CommunityBot

11 silver badge

answered Sep 13, 2010 at 7:59

Martin Hennings

17k9 gold badges51 silver badges70 bronze badges

1 Comment

markoniuss Over a year ago

I thought that reassigning ItemSource will help but to my experience this is not working as expected.

Collectives™ on Stack Overflow

WPF Listbox - data binding problem

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related