AngularJs Error : $http request though defined in controller

Question

I have following code, in which I am calling a service of .php to return data which will later update my model & view. Though, I injected the service name and http in the controller still it gives me error.

HTML:

<html>
<head>
    <script src="https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.4.8/angular.min.js"></script>
</head>
<body ng-app="myApp" ng-controller="myCtrl"> 
    <button ng-click="changeIt()">Change Name</button>{{name}}
    <script>
        //Module declaration
        var app = angular.module('myApp',[]);
        //controller declaration
        app.controller('myCtrl', function($scope, getName, $http){
            $scope.name = "Peter"; 
            $scope.changeIt = function(){
                getName.getTheName()
                    .success(function(data) {
                        $scope.name = data.name;
                    });
            }
        });
        //Service Declaration
        app.service('getName',function(){
            return {
                getTheName: function() {
                    return $http({
                        url: 'hello.php',
                        method: 'Post',
                        headers: {
                            'Content-Type': 'application/json'
                        }
                    });
                },
            }
        });
    </script>
</body> 
</html>

PHP:

<?php
echo $data=json_encode(array('name'=>'Lara'));
?>

Can someone help me out the problem?

oori · Accepted Answer · 2016-04-22 10:56:53Z

2

$http should be defined in the service, not the controller

app.service('getName',function($http){

answered Apr 22, 2016 at 10:56

oori

5,7511 gold badge34 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kshitij · Accepted Answer · 2016-04-22 10:57:26Z

1

You'll need to inject it in service too

app.service('getName',function($http){
            return {
                getTheName: function() {
                    return $http({
                        url: 'hello.php',
                        method: 'Post',
                        headers: {
                            'Content-Type': 'application/json'
                        }
                    });
                },
            }
        });

answered Apr 22, 2016 at 10:57

Kshitij

1238 bronze badges

Comments

Nikhilesh K V · Accepted Answer · 2016-04-22 10:56:48Z

1

You have to inject $http in the service getName where you are using it.

answered Apr 22, 2016 at 10:56

Nikhilesh K V

1,48013 silver badges20 bronze badges

Collectives™ on Stack Overflow

AngularJs Error : $http request though defined in controller

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related