17

I have a class which I want to set up as keys in HashMap. I already have implemented the compareTo method for that class. But still when I do:

map.put(new MyKey(dummyArguements) , dummyValue );
System.out.println(map.get( new MyKey(dummyArguements) ) );

I get null. So that means hashmap is not able to identify that the two keys (for get & put call) are same.

Could someone help me here please ?

7 Answers 7

40

You need to implement hashCode() and equals(). compareTo() is additionally required for sorted map/set.

See this question for details.

Sign up to request clarification or add additional context in comments.

3 Comments

I mean no disrespect (nor do I not believe this to be true), but how do you know this? I've been reading the HashMap documentation over-and-over; following interfaces and inheritances.... and there is nothing that remotely implies the methods mentioned above need to be implemented nor overridden (since they're already inherited from the Object root class) for it to work properly with HashMap.
The definition of some methods on the Map interface establishes some of the rules. For example containsKey() specifically mentions equals(). The hashCode() documentation on Object specifies the relationship between it and equals(). I do however agree with your point - HashMap documentation should reference the hashCode() method and document it's use/requirement for keys of HashMap.
Also you class should be immutable
13

You should implement equals() and hashCode(). Your class should also be immutable. If it is mutable, it's hash code can change after adding it to map. Then the map can have problems finding it.

1 Comment

He is doing new before put and add. So immutable does not matter. Still a good point, +1.
3

1) In general for collections, what you want to override is the equals() method (and also the hashcode() method) for your class. compareTo()/Comparable and Comparator are typically used for sorting and only take the place of using the equals() method for object equivalance in some cases - examples are implementers of SortedSet such as TreeSet.

2) Please conform to Java naming standards in your code. Your class names should be capitalized... e.g new MyKey(dummyArguments). See http://www.oracle.com/technetwork/java/codeconventions-135099.html#367 (and http://www.oracle.com/technetwork/java/codeconvtoc-136057.html) for more detail.

Comments

0

HashMap doesn't check compareTo();

HashMap checks hashCode() and equals().

Comments

0

When using Collections that rely on hashing like Map and Set you have to implement the equals() and hashCode() to guarantee correct functionality. If you don't a new myKey will always be different from the key stored in the map because it uses the default implementations of equals() and hashCode().

Comments

0

Do you have the hashCode() defined? compareTo is needed for sorting.

Comments

0

As of java8 you should also implement Comparable (adding compareTo) because if the number of hash clashes exceeds 11, HashMap stores the entries in a binary tree. If you don't, performance suffers

Comments

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.