Sqlite Database Error : SQLiteLog: (1) near "s": syntax error

Question

I'm having trouble figuring out what this error means: SQLiteLog: (1) near "s": syntax error Mostly because I can't find the database it's running off.

I'm building a movie database android app and the database file I have in my raw directory remains the same and I can't find the DB the build is running off of to fix this.

When using the OMDB api so movies will add to my local database and some will not.

The command I'm using to add is:

MovieDB db = new MovieDB((Context) this);
SQLiteDatabase movDB = db.openDB();
String insert = "insert into movies values('" + movie.title + "','" + movie.year + "','" + movie.rated + "','" + movie.released + "','" + movie.runtime + "','" + movie.genre + "','" + movie.actors + "','" + movie.plot + "',null);";
movDB.execSQL(insert);

I have a feeling it has to do will the null at the end because in my database I have a self incrementing ID which I figured if I passed null it would just assign a value.

Any insight would be much appreciated!

Watch here ,null);";. This may be because of semicolon and null. — Shree Krishna
– Shree Krishna, Commented Mar 30, 2016 at 3:58
Remove ,null. The id (assuming integer primary key) will set to a unique value. — MikeT
– MikeT, Commented Mar 30, 2016 at 3:58
Could it be because of a value with a single quote which is unescaped causing issues with one of your strings? — lodlock
– lodlock, Commented Mar 30, 2016 at 3:59

Thahaseen · Accepted Answer · 2016-03-30 04:27:30Z

1

Recommended way to insert a row in SQLITE is to use contentvalues which is better than executing query. Example below,

public void addMovie(String title, int year){
        SQLiteDatabase db = this.getWritableDatabase();
        ContentValues values = new ContentValues();
        values.put("title", title);
        values.put("year", year);
        db.insert(TABLE_MOVIES, null, values);
        db.close();
    }

answered Mar 30, 2016 at 4:27

Thahaseen

745 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Babbz77 Over a year ago

That fixed it, thanks! For own knowledge do you or anyone know why the way I had it worked for some movies and not others but your way worked for all?

Thahaseen Over a year ago

The second argument in db.insert() method does that magic. Better explained in the docs here. Check the insert() doc developer.android.com/intl/es/reference/android/database/sqlite/…

Babbz77 Over a year ago

Aw makes sense pretty much some values were null, and the middle null value (called the NullColumnHack) will allow for attributes not given to be null. Thus why some inserts worked and some didn't because the ones that were denied must of had null values/unaddressed values. Thanks again @Thahaseen !

Collectives™ on Stack Overflow

Sqlite Database Error : SQLiteLog: (1) near "s": syntax error

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related