array join function not working

Question

for some reason Im not able to see why my array join method wont work. here's the quick code for review:

function rot13(str) { // LBH QVQ VG!
  var strAry = str.split('');

  var transformed = strAry.map(function(val){

    if(val === " ") return " ";
    else{
      var code = val.charCodeAt(0);
      return  String.fromCharCode(code-13);
    }
  });
  transformed.join('');
 console.log(transformed);
  return transformed;
}

// Change the inputs below to test
rot13("SERR PBQR PNZC");

The idea is to pass in the string and it will be converted to a readable code string, but the join is not working. Also, a few of the digits are not converting properly not sure why, bonus points for that one.

kidwon · Accepted Answer · 2016-03-09 00:54:35Z

16

You don't save the result returned of .join()

transformed = transformed.join('');

or

return transformed.join('');

answered Mar 9, 2016 at 0:54

kidwon

4,5345 gold badges31 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Santosh Ram Kunjir · Accepted Answer · 2016-03-09 00:58:55Z

0

Replace this it will work

function rot13(str) { 
// LBH QVQ VG!
  var strAry = str.split('');

  var transformed = strAry.map(function(val){

    if(val === " ") return " ";
    else{
      var code = val.charCodeAt(0);
      return  String.fromCharCode(code-13);
    }
  });
  transformed = transformed.join('');
 console.log(transformed);
  return transformed;
}

jsfiddle link

edited Mar 9, 2016 at 0:58

answered Mar 9, 2016 at 0:56

Santosh Ram Kunjir

1,0821 gold badge13 silver badges23 bronze badges

1 Comment

takendarkk Over a year ago

Instead of saying "Replace this it will work" you should explain what you changed and why.

Collectives™ on Stack Overflow

array join function not working

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related