array in php class "Undefined variable"

Question

I started to learn PHP. I have written a class and I defined an array in that.

<?php

/**
 *
 */
class page {

    public $content= "Coming soon";
    public $title="Saeb Mollayi";
    public $style ="<link rel=\"stylesheet\" type=\"text/css\" href=\"./style/style.css\">";
    public $b = array(
        "خانه"       => 'homepage.php',
        "ارتباط"     => 'contact.php',
        "خدمات"      => 'services.php',
        "نقشه سایت"  =>'sitemap.php',
    );


    function displaymenu()
    {
        echo "<table>"."\r\n";
        echo  " <tr>";
        $width=(100/count($b));

        while (list($name,$url)= each ($b))
        {
            $this -> displaybuttons ($width,$name,$url, $this -> urlbool($url));
        }
        echo "</tr>";
        echo "</table>";
    }

    function ncontent($newcontent)
    {
        $this-> content = $newcontent ;
    }

    function ntitle($newtitle)
    {
        $this -> title = $newtitle ;
    }

    function nbuttons($newbuttons)
    {
        $this -> b = $newbuttons ;
    }

    function display()
    {
        echo "<head>";
        echo "\r\n";

        $this -> displaytitle();
        $this -> style ;

        echo "</head>"."\r\n"."<body>"."\r\n";

        $this -> displayheader();
        $this -> displaymenu($this -> b);

        echo $this -> content ;

        $this -> displayfooter() ;
        echo "</body>"."\r\n";
    }

    function displaytitle()
    {
        echo "<title>";
        echo $this -> title ;
        echo "</title>";
    }

    function displayheader()
    {
        echo '
        <table  id="header">
            <tr id="header">
                <td id="lheader"><img src="./img/logo1.png"></td>
                <td id="cheader"> Welocme. Welcome! </td>
                <rd id="rheader"><img src="./img/logo1.png"></td>
            </tr>
        </table>
        ';
    }

    function urlbool($url)
    {
        if (strpos($_SERVER['SCRIPT_NAME'],$url)==false)
            return false;
        else return true;
    }

    function displaybuttons($width,$name,$url,$active=false)
    {
        if (!active) {
            echo "<td \" style =\"width=$width% ;\">
                <a href ='$url'>
                <img src=\".\img\top.png \" alt='$name' border='0'></a>
                <a href='$url' ><span class='menu'>$name</span></a>
                </td>";
        } else {
            echo "
                <td style='width=$width%'>
                    <img src='./img/right.png'>
                    <span class='menu'>$name</span>
                </td>";
        }
    }

    function displayfooter()
    {
        echo "&copy footer";
    }
}
?>

This is my index.php file:

<html>
<?php
    require "./class/page0.inc";
    $cc = array(
        'خانه'      => 'homepage.php',
        'ارتباط'    => 'contact.php',
        'خدمات'     => 'services.php',
        'نقشه سایت' =>'sitemap.php',
    );

    $ppage = new page();
    $ppage-> nbuttons(array(
        'خانه' => 'homepage.php',
        'ارتباط'=> 'contact.php',
        'خدمات' => 'services.php',
        'نقشه سایت' =>'sitemap.php',
    ));
    $ppage -> ncontent('this is content'."<br>");
    $ppage -> display();
?>
</html>

But when I run it I see these errors:

Notice: Undefined variable: b in /opt/lampp/htdocs/all/test3/class/page0.inc on line 14

Warning: Division by zero in /opt/lampp/htdocs/all/test3/class/page0.inc on line 14

Warning: Variable passed to each() is not an array or object in /opt/lampp/htdocs/all/test3/class/page0.inc on line 15

Where i did do something wrong? What is my fault?

possible to clean up and indent some for readabilities sake? — Fallenreaper
– Fallenreaper, Commented Feb 11, 2016 at 19:27
You are invoking $this -> displaymenu($this -> b); with a parameter - $this -> b, but your function declaration does not have a param -> function displaymenu(){...}. You need to change it to function displaymenu( $b ){...} — Sean
– Sean, Commented Feb 11, 2016 at 19:33
"What is my fault?" - If this happens the first time... not knowing the rules (for accessing member variables) - failing to read the documentation or a book. If this happens again: lazyness. — Karoly Horvath
– Karoly Horvath, Commented Feb 11, 2016 at 20:10

unalignedmemoryaccess · Accepted Answer · 2016-02-11 19:35:53Z

2

Text in errors in readable by humans, they means:

Variable $b does not exist in your function on line 14 in page.inc file.
Because $b does not exists, PHP function "count" will return 0 and you have division by zero.
You are passing variable $b to a function "each", $b does not exists and it is not an array or object.

If you have a variable $b inside class, use $this->b instead to access to it.

answered Feb 11, 2016 at 19:35

unalignedmemoryaccess

7,4722 gold badges29 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

phaberest · Accepted Answer · 2016-02-11 20:07:24Z

1

I don't know if it's because in the copy/paste something went wrong, but editing your post I found out that there are a lot of syntax errors.

First of all those spaces in the objects function calls, where you have unnecessary spaces.

The arrow should not have any space like $this -> displaymenu($this -> b);, it has to be $this->displaymenu($this->b);.

In addition $b must be referenced using $this->b, that's why you get that error about dividing by zero.

answered Feb 11, 2016 at 20:07

phaberest

3,2203 gold badges35 silver badges42 bronze badges

2 Comments

Saeb Molaee Over a year ago

tnx . i must use $this->b every where i have $b in function. tnx

phaberest Over a year ago

You're welcome! If this was your solution it would be kind if you select it as your answer.

Collectives™ on Stack Overflow

array in php class "Undefined variable"

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related