PHP Syntax issue with headers

Question

Can't seem to get it right with the syntax:

<?php 
if isset $_POST['tutorial'] {
    header('Location: /phonebooks?tutorial=1b');
} else {
    header('Location: /phonebooks?phonebook_created=1');
};
?>

What am I doing wrong??

This is basic syntax. You should really read up on it before continuing trying to code in PHP, in my opinion. It will make things go much more smoothly later on. — Jim
– Jim, Commented Aug 13, 2010 at 15:12

ircmaxell · Accepted Answer · 2010-08-13 15:12:43Z

3

Ok, first off, you need to use parenthesis. Multiple parenthesis.

The first set need to go around the contents of the if construct:

if ( ... ) {

The second set need to go around the isset() function call:

isset($_POST['tutorial'])

So that line becomes:

if (isset($_POST['tutorial'])) {

You also have another problem. Don't use location headers with relative urls. It's against the HTTP specification. Always use absolute URLs, otherwise you may break some webservers (I know IIS hates it), or browsers...

answered Aug 13, 2010 at 15:12

ircmaxell

166k36 gold badges269 silver badges316 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Daniel Vandersluis · Accepted Answer · 2010-08-13 15:16:49Z

3

You're missing brackets around your if condition and around $_POST['tutorial'], which is an argument to isset. It should be:

<?php 
if (isset($_POST['tutorial']))
{
  header('Location: /phonebooks?tutorial=1b');
}
else
{
  header('Location: /phonebooks?phonebook_created=1');
}
?>

As pointed out in the comments, an absolute URL is required for a Location header as well (so instead of /phonebooks?tutorial=1b, you'd need to specify http(s)://yourdomain.com/phonebooks?tutorial=1b).

edited Aug 13, 2010 at 15:16

answered Aug 13, 2010 at 15:10

Daniel Vandersluis

94.7k23 gold badges174 silver badges158 bronze badges

3 Comments

TRiG Over a year ago

And Location: headers should, according to the RFC, be full URIs (i.e., they should start with http:// or https://.

Anthony Forloney Over a year ago

Are brackets really necessary for a single condition if statement? It's been a while since I've whipped out the PHP skills.

Daniel Vandersluis Over a year ago

@Anthony Yes, brackets are required around the conditions for all the php keywords that take conditions (if, for, while, etc.)

Collectives™ on Stack Overflow

PHP Syntax issue with headers

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related