Script runs from Bash but not from Automator

Question

I have this automator script that is to be a finder service to process images. The idea is:

I select a bunch of images
I right click and choose the script on Finder services
the script asks me if I want to convert the image to 100x100, 200x200 or 300x300. I can choose multiple options.

Here is what I did: first, a module in applescript that asks me for the sizes I want:

on run
    choose from list {"100", "200", "300"} with prompt "What size(s) do you want? (multiple sizes allowed)" with multiple selections allowed
    set choice to the result as string
    return choice
end run

because this service receive image files, and the following bash script is receiving a list of arguments, this choice variable will be the first on "$@". I need to remove it as the bash script (the next part) starts.

Here is the bash script:

#!/bin/bash

# here is the parameters passed to the functions
# $1 path to the file to be processed
# $2 original image name
# $3 original image directory

function f100 {
   sips -z 100 100 "$1" --out "$3"/"$2"_file100.png
   sips -z 200 200 "$1" --out "$3"/"$2"[email protected]
}

function f200 {
   sips -z 200 200 "$1" --out "$3"/"$2"_file200.png
   sips -z 400 400 "$1" --out "$3"/"$2"[email protected]
}

function f300 {
   sips -z 300 300 "$1" --out "$3"/"$2"_file300.png
   sips -z 600 600 "$1" --out "$3"/"$2"[email protected]
}

choice=$1
shift

for f in "$@"; do

  DIRNAME="$(dirname "$f")"

  filename=$(basename "$f")
  name="${filename%.*}"
  extension="${filename##*.}"


  if [[ $choice == *"100"* ]]
  then 
    f100 $f $filename $DIRNAME 
  fi

  if [[ $choice == *"200"* ]]
  then
    f200 $f $filename $DIRNAME
   fi

  if [[ $choice == *"300"* ]]
  then  
    f300 $f $filename $DIRNAME 
  fi

done

The Applescript part passes the choice as a string to the script. So, if I choose 100 and 200 it will pass a string "100200". If I choose all 3 options, it will pass "100200300", this is why I am searching for the substring on the ifs and running the proper functions.

This script works perfectly from terminal but does nothing when installed as a service on finder. No error, nothing.

jackjr300 · Accepted Answer · 2016-01-06 18:20:13Z

1

This is because the "Run Shell Script" action does not receive the files, the AppleScript must return the input, like this

on run {input, parameters}
    choose from list {"100", "200", "300"} with prompt "What size(s) do you want? (multiple sizes allowed)" with multiple selections allowed
    set beginning of input to the result as string
    return input
end run

Or

on run {input, parameters}
    choose from list {"100", "200", "300"} with prompt "What size(s) do you want? (multiple sizes allowed)" with multiple selections allowed
    set choice to the result as string
    return {choice} & input
end run

Updated

I tested only on files whose path does not contain spaces or special characters.

You must enclose each variable with a double quotes character.

function f100 {
   sips -z 100 100 "$1" --out "$3"/"$2"_file100.png
   sips -z 200 200 "$1" --out "$3"/"$2"[email protected]
}

function f200 {
   sips -z 200 200 "$1" --out "$3"/"$2"_file200.png
   sips -z 400 400 "$1" --out "$3"/"$2"[email protected]
}

function f300 {
   sips -z 300 300 "$1" --out "$3"/"$2"_file300.png
   sips -z 600 600 "$1" --out "$3"/"$2"[email protected]
}

choice=$1
shift
for f in "$@"; do
  DIRNAME="$(dirname "$f")"

  filename=$(basename "$f")
  name="${filename%.*}"
  extension="${filename##*.}"

  if [[ $choice == *"100"* ]]
  then 
    f100 "$f" "$filename" "$DIRNAME"
  fi
  if [[ $choice == *"200"* ]]
  then
    f200 "$f" "$filename" "$DIRNAME"
  fi
  if [[ $choice == *"300"* ]]
  then  
    f300 "$f" "$filename" "$DIRNAME" 
  fi
done

You can test a service in Automator when the service doesn't work.

Select one or two files in the Finder

Insert the "Get Selected Finder Items" action at the first position of the workflow.

Check the result of each action, like this image

I adding some echo "$some variable" to debug the shell script

edited Jan 6, 2016 at 18:20

answered Jan 5, 2016 at 22:19

jackjr300

7,1912 gold badges17 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Duck Over a year ago

I think you may be on the right path but I tried both options and there is no change. The script continues to do nothing.

jackjr300 Over a year ago

I tested the workflow with your shell script, it works without issues. There remains a possibility, if you have the input being passed to stdin, just change the popup menu in the top right (next to the Pass input) to as arguments.

Duck Over a year ago

is it running for you????? I have my script part adjusted "as arguments" and it is not working for me. Is there any way to echo what the script is doing to terminal or something? Can you send me your automator test workflow so I can compare yours with mine? thanks.

Collectives™ on Stack Overflow

Script runs from Bash but not from Automator

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related