How to properly check if array contains an element inside if statement

Question

I have this line of code:

   if ((self.datasource?.contains((self.textField?.text)!)) != nil) {
            if let _ = self.placeHolderWhileSelecting {
               // some code
            }

Is there more clear way to check if the element contains in array? I have Bool returned by contains function, I dont want to check if this Bool is nil

Edit: the solution is to change array to non-optional type.

well that is because your datasource is optional, if your datasource is nil, what do you expect to do? — Knight0fDragon
– Knight0fDragon, Commented Dec 21, 2015 at 19:28
Well, KnightOfDragon, you right. changing optional to non-optional do the trick. Thank you — O.G.O
– O.G.O, Commented Dec 21, 2015 at 19:31
Possible duplicate of How to check if an element is in an array — Nikita Kurtin
– Nikita Kurtin, Commented Dec 21, 2015 at 19:31

Luca Angeletti · Accepted Answer · 2015-12-21 20:46:03Z

1

You can use the if let where construct. This code prevent crashes if self.datasource or self.textField are nil

if let
    list = self.datasource,
    elm = self.textField?.text,
    _ = self.placeHolderWhileSelecting
    where list.contains(elm) {
        // your code
}

edited Dec 21, 2015 at 20:46

answered Dec 21, 2015 at 19:36

Luca Angeletti

59.6k13 gold badges127 silver badges153 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

O.G.O Over a year ago

Wow! this really elegant solution. Gonna learn more about swift if statement

Luca Angeletti Over a year ago

@O.G.O Good! A suggestion for the future. Try to avoid the force unwrap (I mean this !). It's risky and often there is a safer way to unwrap an optional.

jkwuc89 · Accepted Answer · 2015-12-21 19:39:52Z

0

Another possible solution, using optional chaining to get to self.textField.text and assuming datasource remains optional.

if let unwrappedArray = self.datasource, let unwrappedString = self.textField?.text {
    if unwrappedArray.contains(unwrappedString) {
        // Some code
    }
}

answered Dec 21, 2015 at 19:39

jkwuc89

1,47515 silver badges22 bronze badges

2 Comments

jkwuc89 Over a year ago

It looks like my proposed solution is similar to one proposed by appzYourLife above. Concept is generally the same. Unwrap the optionals safely and then, use them.

O.G.O Over a year ago

Yea, thank you for help, mate. appzYourLife was first so i should to accept his answer

Collectives™ on Stack Overflow

How to properly check if array contains an element inside if statement

2 Answers 2

2 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related