OOP and User input as parameters?

Question

I have a question with OOP and best practice. I have only recently grasped OOP in Python. My query is with user input. Most of the examples online do not include it. Is the following code correct interms of OOP best practice or is it very messy with ' ' these as the parameters?

class Userinput(object):

    def __init__(self,name):
        self.name = name

    def askuser(self,call):
        self.call = str(input('Enter in a letter  '))
        print(self.call)


a = Userinput('Test')
a.askuser('')

Do you realize that neither self.name nor the call parameter are used in any way? Also, in python 3, input always returns a string. — Jasper
– Jasper, Commented Dec 17, 2015 at 11:07

John Zwinck · Accepted Answer · 2015-12-17 11:02:54Z

2

Your Userinput class is not providing any value, so just kill it. Classes and OOP are not the only way to write good Python. In your case, stick with a simple function.

answered Dec 17, 2015 at 11:02

John Zwinck

252k44 gold badges346 silver badges459 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

WAMPS Over a year ago

How exactly would I change it to make it a more viable OOP?

John Zwinck Over a year ago

You don't, that's my point. Don't try to jam everything into OOP, it's a mistake. It's simple procedural code, let it be simple.

oystein-hr Over a year ago

Just keep practicing Python, and don't think about OOP yet. OOP can be misused and just make things more complicated than it needs to be. I found this video to be interesting, check it out.

Collectives™ on Stack Overflow

OOP and User input as parameters?

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related