how to loop over angular js object , and add object to the looped

Question

Am trying to loop over an object in angular-js and add an array to object foreach looped object , my code is as below but doesn't seem to work

vm.patients= [
        {[ {"p1": "value1"} ]},
        {[ {"p1": "value1"} ]},
        {[ {"p1": "value1"} ]}

    }];

for(var i=0; i < vm.patients.length; i++){
vm.patients[i].concat([{"z1": "z2",}]);`
}

My aim is to add {"z1": "z2",} to each loop ie the 3 loops arrays so that i end with below

vm.patients= [
            {[ {"p1": "value1"},{"z1": "z2",} ]},
            {[ {"p1": "value1"},{"z1": "z2",} ]},
            {[ {"p1": "value1"},{"z1": "z2",} ]}

        }];

concat however doesn't seem to work , any solution ?

vm.patients is not an array. you need to use brackets [ ] to define an array — Glenn Ferrie
– Glenn Ferrie, Commented Dec 11, 2015 at 14:58
Patients is an object not an array. If you wish to itterate it you should use a for in loop. However the order of properties iterated cannot be predicted or guaranteed. — ste2425
– ste2425, Commented Dec 11, 2015 at 15:00
Are you aware you have an strange accent mark there? ...({"z1": "z2",});` — codebear22
– codebear22, Commented Dec 11, 2015 at 15:03

Luis Masuelli · Accepted Answer · 2015-12-11 15:13:45Z

6

You don't iterate your objects using a for(;;) loop, if they're not array-like objects.

You can iterate with for(in), however:

for(var key in yourObj) {
    if (obj.hasOwnProperty(key)) {
        var value = yourObj[key];
        //your code here
    }
}

Or angularjs-fashion:

angular.forEach(yourObj, function(value, key) {
    // your code here
})

Additionally:

vm.patients[i].concat([{"z1": "z2",}]);

is wrong, since you are calling something like "patient1".concat([{"z1": "z2"}]) which:

Does not alter the value. Try executing in the console the following code:
```
 var x = "a";
 x.concat("b");
 console.log(x);
```
Sounds to be wrong. Try executing the following in the console:
```
 var x = "a";
 console.log(x.concat([{'a':'b'}]))
```
and see what happens.

Tip: If you have troubles with your code, try separating all the code in single instructions and assignments.

Perhaps you intended:

var yourObj = {
    "p1": {"name": "patient1"},
    ... others ...
};
angular.forEach(yourObj, function(value, key) {
    // your code here
    angular.extend(value, {"z1": "z2"})
})

edited Dec 11, 2015 at 15:13

answered Dec 11, 2015 at 15:00

Luis Masuelli

12.4k11 gold badges52 silver badges89 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Nina Scholz Over a year ago

while the question is unclear, the answer remains unclear.

Glenn Ferrie · Accepted Answer · 2015-12-11 15:02:44Z

1

Is this what you are trying to accomplish?

var vm = {};
vm.patients = [{
        "p1": "value1",
        "p2": "value2",
        "p3": "value3"
    }];

for(var i=0; i < vm.patients.length; i++){
    var p = vm.patients[i];
    p["z1"] = "z2";
}
// The result here is that each element in the array will have an
// addition attribute named z1 with the value of "z2".

You had some syntax issues with your JavaScript, but this code is cleaner.

I made patients into an array and modified your other code that affects change on the items in the array.

answered Dec 11, 2015 at 15:02

Glenn Ferrie

10.4k3 gold badges46 silver badges77 bronze badges

1 Comment

Jimmy Obonyo Abor Over a year ago

this looks promising let me test this !

erdysson · Accepted Answer · 2015-12-11 15:12:55Z

1

concat is an Array function, you can not use it over an object. secondly, if you want to use concat, second parameter also should be an array : [1].concat([2,4]). third, you are trying to concat something to a string which is can't be concat with an object. Then, If you want to iterate over the object and extend it, you should do :

Object.keys(obj).forEach(function(ob) {
  obj[ob] = Object.assign(obj[ob], {newParam1: 1, newParam2: 2});
});

but you code in angular this is more appropriate :

angular.forEach(obj, function(v) {
  v = angular.extend(v, {newValue1: 1, newValue2: 2});
});

answered Dec 11, 2015 at 15:12

erdysson

1,49013 silver badges18 bronze badges

2 Comments

Jimmy Obonyo Abor Over a year ago

what does v stand for ?

erdysson Over a year ago

object instance in your array

Nina Scholz · Accepted Answer · 2015-12-11 15:42:56Z

1

Assuming you have a data structure like

vm.patients = [{ p1: "value1" }, { p1: "value1" }, { p1: "value1" }];

then this would work:

var vm = {};
vm.patients = [{ p1: "value1" }, { p1: "value1" }, { p1: "value1" }];

vm.patients.forEach(function (a) {
    a.z1 = 'z2';
});

document.write('<pre>' + JSON.stringify(vm.patients, 0, 4) + '</pre>');

edited Dec 11, 2015 at 15:42

answered Dec 11, 2015 at 15:27

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Collectives™ on Stack Overflow

how to loop over angular js object , and add object to the looped

4 Answers 4

1 Comment

1 Comment

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

1 Comment

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related