PHP if statement?

Question

Hi i wonder what i might be doing wrong. I have two conditions that returns true or false.For same reason it doesnt work. I would appreciate if someone point out what i might be doing wrong.

<?php  
  $pagetype = strpos($currentPage, 'retail');
  if(isset($quoterequest) && $pagetype === True && $currentPage !== 'index.php'){
    echo "this is retail" ;
  }elseif(isset($quoterequest) && $pagetype === False && $currentPage !== 'index.php'){
    echo "this is restaurant";
  }                               
?>

EDIT- Sorry i edit it but didnt show up for some reason. Basically script looks into urls for term "retail" if it finds it, it should return "this is retail" if not "this is restaurant"

quoterequest is a just a variable like so

$quoterequest = "washington"

and the currentpage is driven from

<?php $currentPage = basename($_SERVER['SCRIPT_NAME']);

Just to be clear. Url is structure like so

www.example.com/retail-store.php www.example.com/store.php

What's happening and what do you want to have happen here? Is it not going into the clause you expect or is it going into neither one? — Dylan West
– Dylan West, Commented Aug 5, 2010 at 20:05
Could we get some samples of the values of $currentPage and $quoterequest — Phliplip
– Phliplip, Commented Aug 5, 2010 at 20:05
And does it say 'this is retail' or 'this is restaurant' - or neither? — Phliplip
– Phliplip, Commented Aug 5, 2010 at 20:06

NikiC · Accepted Answer · 2010-08-05 20:06:28Z

6

$pageType is never true. If the string is contained, strpos returns an integer. So test for !== false.

<?php  
    $pagetype = strpos($currentPage, 'retail');
    if (isset($quoterequest) && $currentPage !== 'index.php') {
        if ($pagetype !== false) {
            echo "this is retail";
        }
        else {
            echo "this is restaurant";
        }
    }                     
?>

answered Aug 5, 2010 at 20:06

NikiC

102k39 gold badges194 silver badges226 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

vlad b. · Accepted Answer · 2010-08-05 20:06:12Z

1

At first look it should be $pagetype !== false
strpos return false or a numeric value on match

quote from php.net/strpos

Returns the position as an integer. If needle is not found, strpos() will return boolean FALSE.

so, to check if the value is not found you should use if(strpos(...)===false) and to check if it's found you should use if(strpos(...)!==false)

answered Aug 5, 2010 at 20:06

vlad b.

6955 silver badges15 bronze badges

Comments

Doon · Accepted Answer · 2010-08-05 20:15:46Z

1

no sense in duplicating the conditions each time either. The below code should do what you want.. (taking into account the aforementioned strpos comments).

$pagetype = strpos($currentPage, 'retail');
if($currentPage !== 'index.php' && isset($quoterequest)){
   if ($pagetype === false){
     echo "restaurant";
   }else{
     echo "retail"; 
   }
}

answered Aug 5, 2010 at 20:15

Doon

20.3k3 gold badges42 silver badges44 bronze badges

1 Comment

Doon Over a year ago

dang I need to type faster... :)

user151841 · Accepted Answer · 2010-08-05 20:20:36Z

0

PHP has lazy evaluation. If the first term in an if statement evaluates to false, it will stop evaluating the rest of the code. If isset($quoterequest) evaluates to false, nothing else in either of your statements will be examined.

$>
<?php

function untrue() {
        return FALSE;
}

function truth() {
        echo "called " . __FUNCTION__ . "\n!";
        return TRUE;
}

if ( untrue() && truth() ){
        echo "Strict.\n";
} else {
        echo "Lazy!\n";
}

$> php test.php
Lazy!

answered Aug 5, 2010 at 20:20

user151841

18.1k32 gold badges120 silver badges178 bronze badges

Collectives™ on Stack Overflow

PHP if statement?

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related