mysql insert statement in PHP form

Question

I want to show a list in PHP with the entries in a mysql-database. it works, now in the same .php file, a form should insert a new entry in the database, and it should be then shown in the list. My attempts have failed, where the last entry is always inserted in the database upon every access to the site. Below is my code:

PHP-Part adminlist.php:

$adminname = mysqli_real_escape_string($con, $_POST['adminname']);
    $server = mysqli_real_escape_string($con, $_POST['server']);

if(!empty($adminname && $server))
{
    $insert =  "INSERT INTO admins (ID, Name, Passwort, Server, Anmeldungen) VALUES (NULL, '" . $adminname . "', '', '" . $server . "', '0')";
    $insertquery = mysqli_query($con, $insert);
}

HTML-Part adminlist.php:

<form name='einfuegen' action='adminlist.php' method='post'>
            <table>
                <tr>
                    <th>Name</th>
                    <th>Server</th>
                </tr>
                <tr>
                    <td><input name='adminname' value='' /></td>
                    <td><input name='server' value='' /></td>
                    <td><input type='submit' value='Einf&uuml;gen' /></td>
                </tr>
            </table>
        </form>

I've tried also to set under the form

$server = 0;
$adminname = 0;

and edited the above:

if(!empty($adminname && $server) && ($server != 0) && ($adminname != 0))

In this case it won't work and nothing is inserted. How could I set only one to be inserted and be shown then in the list?

Please use if(!empty($adminname) && !empty($server)) instead of if(!empty($adminname && $server)) — mario.van.zadel
– mario.van.zadel, Commented Dec 8, 2015 at 6:56
@mapek better yet, just use if($adminname && $server), as both of those variables are already defined. — user3714134
– user3714134, Commented Dec 8, 2015 at 12:47

Nana Partykar · Accepted Answer · 2015-12-09 06:58:28Z

3

Change this if(!empty($adminname && $server)) with if(!empty($adminname) && !empty($server)) And, don't unnecessary concatenate values for inserting.

Edited Code

if(!empty($adminname) && !empty($server))
{
    $insert =  "INSERT INTO admins (ID, Name, Passwort, Server, Anmeldungen) VALUES (NULL, '$adminname','', '$server', '0')";
    $insertquery = mysqli_query($con, $insert);
}

For OP :

Use header("location:adminlist.php"); for redirecting it after submitting.

<?php
error_reporting(0);

if($_POST['submitValue']) {

    $adminname = mysqli_real_escape_string($con, $_POST['adminname']);
    $server = mysqli_real_escape_string($con, $_POST['server']);

    $insert =  "INSERT INTO admins (ID, Name, Passwort, Server, Anmeldungen) VALUES (NULL, '$adminname','', '$server', '0')";
    $insertquery = mysqli_query($con, $insert);

    header("location:adminlist.php");

}?>



<form name='einfuegen' action='' method='post'>
    <table>
        <tr>
            <th>Name</th>
            <th>Server</th>
        </tr>
        <tr>
            <td><input name='adminname' value='' /></td>
            <td><input name='server' value='' /></td>
            <td><input type='submit' name='submitValue' value='Einf&uuml;gen' /></td>
        </tr>
    </table>
</form>

edited Dec 9, 2015 at 6:58

answered Dec 8, 2015 at 6:58

Nana Partykar

10.5k10 gold badges50 silver badges79 bronze badges

Sign up to request clarification or add additional context in comments.

18 Comments

Anand G Over a year ago

BTW your profile is the funniest one I ever seen on SOF. No serious business at all. LOL!

Nana Partykar Over a year ago

Thanku @AnandG Jee. Be Funny. Go Sunny

user5629752 Over a year ago

So I do not need the " $server = 0; $adminname = 0;" at he bottom?

Nana Partykar Over a year ago

No. No. It's Not Like That. Why Unnecessary concatenating '" . $adminname . "'. It's not an error. Just for better way to write code. I feel easy this way only @JohnHSmith

user5629752 Over a year ago

But how can I delete the last given words in form after refreshing the page?

|

Collectives™ on Stack Overflow

mysql insert statement in PHP form

1 Answer 1

18 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

18 Comments

Your Answer

Sign up or log in

Post as a guest

Related