Executing Server and Client functions from client side with php and js

Question

After the client presses a button - a server side function must be executed and according the result different client side functions be executed..

To achive this I used AJAX and wrote this function :

function invoke_php(file_name, parameters){     
   parameters = typeof parameters !== 'undefined' ? parameters : '';
   var xmlhttp = new XMLHttpRequest();
   xmlhttp.onreadystatechange = function() {
       if (xmlhttp.readyState == 4 && xmlhttp.status == 200) {             
           switch (xmlhttp.responseText) {
             case "func1":
                func1();
             break;
             case "func2":
                func2();
             break;
             default:
                default_func();
           } 
       }
   };
   xmlhttp.open("POST", file_name+"?"+parameters, true);
   xmlhttp.send();
}

Server side functionality is performed in separate php file, which returns the name of the function to run. the invoke_php function uses switch on the respone text and execute the suitable client-side function...

It feels like there is a better way to do this.... Any improvement suggestion will be appreciated..:)

Benjamin Chelli · Accepted Answer · 2015-11-27 12:57:33Z

I would recommend you to:

remove the switch case (which is usually not efficient and tend to become very verbose)
pass the full URL to the function
pass the list of callbacks to the function, in that way you won't rely on global definition of callbacks

Here is what the code could look like:

function invoke_php(url, callbacks){
    var xmlhttp = new XMLHttpRequest();
    xmlhttp.onreadystatechange = function() {
        if (xmlhttp.readyState == 4 && xmlhttp.status == 200 && callbacks) {
            var fn = callbacks[xmlhttp.responseText] || callbacks._default || function () {};
            fn();
        }
    };
    xmlhttp.open("POST", url, true);
    xmlhttp.send();
}

invoke_php(
    'test.php?myparams=true',
    {
        _default: function () {},
        func1: function () {
            console.log('func1');
        },
        func2: function () {
            console.log('func2');
        },
    }
);

Let me know if this helps.

Thanks

Collectives™ on Stack Overflow

Executing Server and Client functions from client side with php and js

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related