Declare variable to return Json result (ASP.NET MVC4)

Question

This is action from my controller

[HttpPost]
[AjaxAction]
public ActionResult Registration(RegisterUserModel registerUser)
{
    var data;

    if (ModelState.IsValid)
    {
        if (!IsUserExist(registerUser.Email))
        {    

            var crypto = new SimpleCrypto.PBKDF2();

            var encrpPass = crypto.Compute(registerUser.Password);

            var newUser = _db.Users.Create();

            newUser.Name = registerUser.Name;
            newUser.Email = registerUser.Email;
            newUser.Type = UserType.User.ToString();

            newUser.Password = encrpPass;
            newUser.PasswordSalt = crypto.Salt;

            _db.Users.Add(newUser);
            _db.SaveChanges();

            data = new { status = "OK", message = "Success" };

        }
        else
        {

            data = new { status = "ERROR", message = "User already exists" };
        }
    }
    else
    {

        data = new { status = "ERROR", message = "Data is incorrect" };
    }
    return Json(data, JsonRequestBehavior.AllowGet);
}

but I don't know how to initialize data variable in the right way, because I need to set different values in different cases. What is the right way to do that?

Muhammad Adeel Zahid · Accepted Answer · 2015-11-25 17:49:50Z

2

I usually use multiple return statements to avoid having to declare an object like

if(something){
return Json(new{status = "status 1", message = "message1"})
}
else{
return Json(new{status = "status 2", message = "message2"})
}

answered Nov 25, 2015 at 17:49

Muhammad Adeel Zahid

17.8k16 gold badges95 silver badges160 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Fran Over a year ago

just an FYI. the else statement isn't needed if can be written if (true) { return 'whatever' } return 'whatever';

Heidel Over a year ago

@Fran great notice, but actually I don't like to have multiple returns in my actions, I prefer to have the one. Maybe I'm not right.

Ariel Batista · Accepted Answer · 2015-11-25 17:44:05Z

2

you can try this:

var data = new object();

answered Nov 25, 2015 at 17:44

Ariel Batista

1541 silver badge5 bronze badges

3 Comments

Muhammad Adeel Zahid Over a year ago

how do you populate the status and message property with an object

Muhammad Adeel Zahid Over a year ago

As far, as I know, there are no public properties available with System.Object

Muhammad Adeel Zahid Over a year ago

And also, the code would not compile if you initialize data as object and then assign it an anonymous object with two properties. Dot Net creates types for anonymous objects on the fly

Nitesh Kumar · Accepted Answer · 2015-11-25 18:15:48Z

2

Here is one of the options

[HttpPost]
[AjaxAction]
public ActionResult Registration(RegisterUserModel registerUser)
{
    JsonResult data;

    if (ModelState.IsValid)
    {
        if (!IsUserExist(registerUser.Email))
        {    

            var crypto = new SimpleCrypto.PBKDF2();

            var encrpPass = crypto.Compute(registerUser.Password);

            var newUser = _db.Users.Create();

            newUser.Name = registerUser.Name;
            newUser.Email = registerUser.Email;
            newUser.Type = UserType.User.ToString();

            newUser.Password = encrpPass;
            newUser.PasswordSalt = crypto.Salt;

            _db.Users.Add(newUser);
            _db.SaveChanges();

            data = Json(new { status = "OK", message = "Success" }, JsonRequestBehavior.AllowGet);

        }
        else
        {

            data = Json(new { status = "ERROR", message = "User already exists"}, JsonRequestBehavior.AllowGet);
        }
    }
    else
    {

        data = Json(new { status = "ERROR", message = "Data is incorrect" }, JsonRequestBehavior.AllowGet);
    }
    return data;
}

answered Nov 25, 2015 at 18:15

Nitesh Kumar

1,7744 gold badges19 silver badges27 bronze badges

1 Comment

Heidel Over a year ago

Thanks a lot, interesting idea.

Amadeus Sanchez · Accepted Answer · 2015-11-25 17:54:11Z

1

You can use the dynamic keyword.

dynamic data;

answered Nov 25, 2015 at 17:54

Amadeus Sanchez

2,6252 gold badges28 silver badges33 bronze badges

Collectives™ on Stack Overflow

Declare variable to return Json result (ASP.NET MVC4)

4 Answers 4

2 Comments

3 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

3 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related