jQuery/JavaScript - passing variables to functions

Question

I have a function that looks like so:

window.attack = function(enemyHealth){ 
        attackChance = Math.floor(Math.random()*11);
        console.log("enemyHealth: "+enemyHealth); //undefined...
        if (attackChance < 5) { //hit
            hitDamage = Math.floor(Math.random()*playerDamage+1);
            enemyHealth = enemyHealth - hitDamage;
            $('#enemyhealth').val(enemyHealth);
            if (enemyHealth < 1) {
                alert('You killed the '+currentEnemy);
                removeOverlayNow();
            }
        } else if (attackChance >= 5) { //miss
            hitDamage = Math.floor(Math.random()*maxDamage+1); 
            alert('You miss and get attacked for '+hitDamage);
            health = health - hitDamage; 
            $(healthDisplay).val(health); 
            checkHealth(); 
        }
    }

And my variable is being thrown in via:

onclick="flee('+currentEnemyHealth+')"

But when I console.log or alert() all I get is Undefined...

Am I missing a trick here? I thought that if I pass a variable into the function (in this case enemyHealth), that I should be able to retrieve it?

Thanks.

p.s.
Just thought I would state that even if I pass a card-coded number (such as 5) through the function - it still arrives as Undefined

where's the code for calling window.attack? From the look of it that is not passing a value — DanSingerman
– DanSingerman, Commented Aug 2, 2010 at 13:18

Ash Burlaczenko · Accepted Answer · 2010-08-02 13:19:06Z

1

You call should be

onclick="flee(" + currentEnemyHealth + ")"

Hope this helps.

answered Aug 2, 2010 at 13:19

Ash Burlaczenko

25.6k16 gold badges70 silver badges103 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

AlG · Accepted Answer · 2010-08-02 13:17:19Z

1

Are you sure you don't mean:

onclick="flee("+currentEnemyHealth+")"

Fixing the quoting so that the value of currentEnemyHealth is embedded into the string?

answered Aug 2, 2010 at 13:17

AlG

15.3k4 gold badges43 silver badges54 bronze badges

Comments

Thierry Roy · Accepted Answer · 2010-08-02 13:17:34Z

0

currentEnemyHealth is not in the scope of the javascript calls.

answered Aug 2, 2010 at 13:17

Thierry Roy

8,51210 gold badges62 silver badges87 bronze badges

Collectives™ on Stack Overflow

jQuery/JavaScript - passing variables to functions

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related