Python Getters and Setters

Question

How should I access the class instance variables in my `roll` method?

Should I access self._value with self._value or use my setter by accessing with self.value? Same question for self._sides.

import random


class MSDie:
    def __init__(self, sides):
        self._sides = sides
        self._value = 1

    @property
    def sides(self):
        return self._sides

    @property
    def value(self):
        return self._value

    @value.setter
    def value(self, number):
        self._value = number

    def roll(self):
        self._value = random.randrange(1, self.sides + 1)

So basically, should I create the roll method like this instead:

def roll(self):
    self.value = random.randrange(1, self.sides + 1)

Now I know how to do it correctly the conventional way of get_value/set_value but I am trying to learn how to create more pythonic classes.

Just out of curiosity, why doesn't self.value(random.randrange(1, self.value + 1) or self.value(self, random.randrange(1, self.sides + 1) access the self._value variable and change it?

Daniel · Accepted Answer · 2015-11-22 10:32:36Z

4

In your current implementation, the value-property is of no use. If you have a setter with, for example, additional checks, you have to decide, if roll needs the additional checks or not. If not sure, use self.value.

answered Nov 22, 2015 at 10:32

Daniel

42.9k4 gold badges57 silver badges82 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Clever Programmer Over a year ago

In what case WOULD be my value-property of use? I am just learning about these decorators.

Collectives™ on Stack Overflow

Python Getters and Setters

How should I access the class instance variables in my `roll` method?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

How should I access the class instance variables in my roll method?

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related

How should I access the class instance variables in my `roll` method?