Function to skip empty variable during concatenation in PHP

Question

Rookie question but can someone help with a simple function to skip empty variables during concatenation in PHP and add a comma.

Example;

$addressline1 = "Street";
$addressline2 = "";
$addressline3 = "London";

I want to get;

$concataddress = "Street, London";

And not;

$concataddress = "Street, , London";

I'm getting the addresses from mysql DB I can obviously use if...else statement and check if(empty($addressline1)) etc but looking for something efficient and simple.

Thanks!

implode(', ',array_filter(array($addressline1,$addressline2...))) — Vatev
– Vatev, Commented Nov 11, 2015 at 9:35
Why are you thinking if(){}else{} and inbuild functions e.g. empty() are not efficient and simple? — Domain
– Domain, Commented Nov 11, 2015 at 9:38
@Vatev thanks mate. Please put it as answer and I'll accept. — moh_abk
– moh_abk, Commented Nov 11, 2015 at 9:46

Richard Merchant · Accepted Answer · 2015-11-11 09:39:00Z

2

You could place them in an array and use array filter with implode

$address = implode(", ", array_filter(array($addressline1, $addressline2, $addressline3));

answered Nov 11, 2015 at 9:39

Richard Merchant

1,00313 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Darragh Enright Over a year ago

Boom. Beat me to it :)

Richard Merchant Over a year ago

Looks like @Vatev beat me to it too

Vatev · Accepted Answer · 2015-11-11 09:50:57Z

1

array_filter without a callback will remove all elements which evaluate to false.

$concatAddress = implode(', ', array_filter(array(
    $addressline1,
    $addressline2,
    $addressline3,
    ...
)));

answered Nov 11, 2015 at 9:50

Vatev

7,5801 gold badge36 silver badges42 bronze badges

Comments

Audite Marlow · Accepted Answer · 2015-11-11 09:39:02Z

0

Try what Vatev suggested:

$array = array(
    'Street',
    '',
    'London',
);

$concatAddress = implode(', ', array_filter($array));

echo $concatAddress;

answered Nov 11, 2015 at 9:39

Audite Marlow

1,0641 gold badge8 silver badges25 bronze badges

Comments

Erwin Moller · Accepted Answer · 2015-11-11 09:38:54Z

-1

You won't get much more efficient with variablenames.

If you store it in an array, you might get more efficient, in the way your code looks good, not in speed really.

for example:

function getAdres($ARR_adresParts){
  $adres = array();
  foreach($ARR_adresParts as $onePart){
    if ($onePart !== ""){
      $adres[] = $onePart;
    }
  }
  return implode(", ",$adres);
}

And then call it like:

$adr = getAdres(array($addressline1,$addressline2,$addressline3));

Not nice, but given the situation I doubt it will become more beautiful then something like that. :-)

answered Nov 11, 2015 at 9:38

Erwin Moller

2,40816 silver badges23 bronze badges

Collectives™ on Stack Overflow

Function to skip empty variable during concatenation in PHP

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related