Python: Variable not defined?

Question

So, I have this stuff below

def userinput():
    adjective1 = input("Adjective: ")
    noun1 = input("Noun: ")
    noun2 = input("Noun: ")

def story():
    print("A vacation is when you take a trip to some " + adjective1 + " place.")
    print("Usually you go to some place that is near " + noun1 + " or up on " + noun2 + ".")

then when I run the functions and provide input, it comes back with

 File "/Users/apple/Dropbox/MadLibs 6.py", line 52, in story
print("A vacation is when you take a trip to some " + adjective1 + " place with your "+ adjective2 + " family.")
NameError: name 'adjective1' is not defined

What does it mean by this, and how can I fix it?

you need to set the two variable as global.

Avinash Raj
– Avinash Raj

2015-11-08 15:52:31 +00:00
Commented Nov 8, 2015 at 15:52 — Avinash Raj
– Avinash Raj, Commented Nov 8, 2015 at 15:52

Netwave · Accepted Answer · 2015-12-01 08:08:16Z

7

Its all about scope, you can not acces variable within another function scope Try this:

def userinput():
    adjective1 = input("Adjective: ")
    noun1 = input("Noun: ")
    noun2 = input("Noun: ")
    return adjective1, noun1, noun2

def story():
    adjective1, noun1, noun2 = userinput()
    print("A vacation is when you take a trip to some " + adjective1 + " place.")
    print("Usually you go to some place that is near " + noun1 + " or up on " + noun2 + ".")

By calling userinput on the second function and getting its returned info you can access it. Notice that adjective1, noun1 and noun2 form story function are locally scoped in that function so they are diferent from the userinput variables although they are named equally.

edited Dec 1, 2015 at 8:08

answered Nov 8, 2015 at 15:58

Netwave

43.1k6 gold badges69 silver badges110 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 12:15:12Z

0

Those variables are local to the function. This answer provides a good summary of the scoping in Python - Short Description of the Scoping Rules?.

You generally want to limit the available scope of variables as much as possible where practical, likely using function arguments in a case like this.

edited May 23, 2017 at 12:15

CommunityBot

11 silver badge

answered Nov 8, 2015 at 15:58

Will Hogan

9195 silver badges10 bronze badges

Comments

leela.fry · Accepted Answer · 2015-11-08 16:06:58Z

0

Try this:

def userinput():
    global  adjective1
    adjective1 = input("Adjective: ")
    global noun1
    noun1 = input("Noun: ")
    global noun2
    noun2 = input("Noun: ")

def story():
    print("A vacation is when you take a trip to some " + adjective1 + " place.")
    print("Usually you go to some place that is near " + noun1 + " or up on " + noun2 + ".")

answered Nov 8, 2015 at 16:06

leela.fry

2992 gold badges3 silver badges13 bronze badges

4 Comments

Netwave Over a year ago

Its a posibility, but teaching this to someone that dont know how to handle scope is not a very good practice :)

leela.fry Over a year ago

@DanielSanchez I find it practical and necessary when building games for example.

Netwave Over a year ago

I've worked on a couple of titles and I think that declaring a global variable inside a function is not a good practice. Make them global by scopping them outside (and declaring global too if you require it). It's just my opinon, your code is another working option too :)

leela.fry Over a year ago

I agree with you @DanielSanchez, however that script seems to look a bit like a game and that option may be good for it.

Collectives™ on Stack Overflow

Python: Variable not defined?

3 Answers 3

Comments

Comments

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related