Calling JS Functions from OnClick with Parameters

Question

I'm trying to call a js function from the OnClick within multiple DIVs, it passes a 'Section Name' secOther001, 002, 003 etc...'.

<?php
$num=mysql_numrows($result);

$i=0;
while ($i < $num) {

$TaskID=sprintf("%03d",mysql_result($result,$i,"TaskID"));
$secOthersID = "SecOther$TaskID";
echo "
<div class='clTaskSection' onclick='SecOtherVisibility($secOthersID)'>...</div>
<div id='$secOthersID' class='clTaskSection'>content...</div>";

$i++;
}

?>

it should then call the js below, providing the relevant section name:

<script>
function SecOtherVisibility(divName) {
    if (document.getElementById(divName).style.display = "none") {
      document.getElementById(divName).style.display = "block"
    } else {
      document.getElementById(divName).style.display = "none";
    }
}
</script>

But I get Uncaught TypeError: Cannot read property 'style' of null. Where am I going wrong?

PHP Pulls records from a MySQL DB to create nested DIVs with the record data. PHP defines $secOthersID — aSystemOverload
– aSystemOverload, Commented Nov 7, 2015 at 23:31

Niet the Dark Absol · Accepted Answer · 2015-11-07 23:36:06Z

1

More importantly, look at the rendered result:

... onclick='SecOtherVisibility(SecOther001)' ...

Do you see the problem?

How about now:

... onclick='SecOtherVisibility(<?=json_encode($secOthersID)?>)' ...

Outputs:

... onclick='SecOtherVisibility("SecOther001")' ...

I hope that clears things up!

answered Nov 7, 2015 at 23:36

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

aSystemOverload Over a year ago

Now I just get [Uncaught SyntaxError: Unexpected token <]

aSystemOverload Over a year ago

Updated with additional info... <DIV>s are within an echo"..."

Niet the Dark Absol Over a year ago

Then just close the quotes - 'SecOtherVisibility(".json_encode($secOthersID).");'

MiDri · Accepted Answer · 2015-11-07 23:23:28Z

1

Change it to this:

<div class='clTaskSection' onclick='SecOtherVisibility(<?= $secOthersID ?>)'>...</div>

You can't just use PHP variables unless in PHP context.

answered Nov 7, 2015 at 23:23

MiDri

7473 silver badges13 bronze badges

4 Comments

aSystemOverload Over a year ago

Now I just get [Uncaught SyntaxError: Unexpected token <]

MiDri Over a year ago

Might not have shorthand enabled try: <?php echo $secOthersID ?> instead of <?= $secOthersID ?>

MiDri Over a year ago

Ahh I think that's throwing everyone who has answered you off.

aSystemOverload Over a year ago

Updated with additional info... <DIV>s are within an echo"..."

Sasha Pachev · Accepted Answer · 2015-11-07 23:37:58Z

1

The function expects a string as divName. You are passing the variable $secOthersID, which is undefined. Your HTML needs to be something like:

<div class='clTaskSection' id="cats" onclick='SecOtherVisibility("cats")'>Contents of div...</div>

edited Nov 7, 2015 at 23:37

Sasha Pachev

5,3363 gold badges23 silver badges20 bronze badges

answered Nov 7, 2015 at 23:22

Streetlamp

1,5462 gold badges15 silver badges27 bronze badges

5 Comments

aSystemOverload Over a year ago

Thanks for the suggestion, but this doesn't work as it has to pass a dynamic value, will try MiDri's example.

Streetlamp Over a year ago

Sorry. I used the wrong quotation marks. Thanks to @SashaPachev for the fix.

aSystemOverload Over a year ago

Note that secOthersID is not undefined as if you check the source it is 'secOther001', 'secOther002' etc...

Streetlamp Over a year ago

@aSystemOverload But that's part of the PHP, which never reaches the user. Could you post a more complete section of you PHP script? Are the <input />s generated in a loop?

aSystemOverload Over a year ago

Updated with additional info... <DIV>s are within an echo"..."

Collectives™ on Stack Overflow

Calling JS Functions from OnClick with Parameters

3 Answers 3

3 Comments

4 Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

4 Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related