JavaScript/JQuery event handler problem

Question

Been playing around a bit with JavaScript/JQuery, and made a "shy" button, instead its just a p-tag with a word. It works ok, except the bool goDown doesn't seem to change, so it always goes down. What's wrong with my code?

Also JavaScript debugging in VS2010 doesn't seem to be working very good, is this a known problem?

Thanks in advance!

if (typeof naarBeneden == 'undefined') {
    var goDown = new Boolean(true);
}

$(document).ready(function () {

    $(".moveme").animate({ "left": "+=500px"
    }, 2000);
    $(".moveme").hover(move());
});


function move() {
    if (goDown) {
        $(".moveme").hover(function () {
            $(this).animate({ "top": "+=50px" }, 0)
        });
        goDown = false;
    }
    else {
        $(".moveme").hover(function () {
            $(this).animate({ "top": "-=50px" }, 0)
        });
        goDown = true;
    }
}

Aside: never use new Boolean. It doesn't do anything you'd ever want, and has weird behaviours like new Boolean(false)? 1:0 being 1. — bobince
– bobince, Commented Jul 29, 2010 at 0:02

Nick Craver · Accepted Answer · 2010-07-28 23:50:16Z

1

The main issue is here:

$(".moveme").hover(move());

You're calling move() not using move as a handler, you need it without the parenthesis, like this:

$(".moveme").hover(move);

Even doing that though, you're assigning a new .hover() handler on each hover event, and I doubt that's really what you're after. It's hard to tell exactly what you're after, but I think this is it:

$(function () {
  var goDown = typeof naarBeneden != 'undefined';
  $(".moveme").animate({ "left": "+=500px" }, 2000);
              .hover(function () {
                $(this).animate({ "top": goDown ? "+=50px" : "-=50px" }, 0);
              }, function() {
                $(this).animate({ "top": !goDown ? "+=50px" : "-=50px" }, 0);
              });
});

This assigns an up then down animation if goDown is true when you hover/leave the element, and it does the reverse if goDown is false.

edited Jul 28, 2010 at 23:50

answered Jul 28, 2010 at 23:44

Nick Craver

631k138 gold badges1.3k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

JavaScript/JQuery event handler problem

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related