passing return value from a php function to a mysql_query

Question

I am having a problem with passing a $query variable to a mysql_query command. So if I do this I get an update in the database (which I wanted):

$query = "UPDATE master SET finished_size = '$finished_size' WHERE id = $id";
mysql_query ($query, $db);

However, I need to use a function to do this. I'm trying to use this code, but I am no longer able to get the update to the database that I wanted:

if ( !function_exists("testQuery") ) {
    function testQuery($id) {
        return 'UPDATE master SET finished_size = "$finished_size" WHERE id = $id';
    }
}

$query = testQuery($id);

mysql_query ($query, $db);

I have tried many ways of doing this, but the $query variable which contains the string to pass to the mysql_query function doesn't seem to be recognized. But I don't know how else to do this the proper way.

Also, I realize mysql_query is an old function, but this is the code that I have to use because I'm working on very old software.

Stop what you're doing: stackoverflow.com/questions/12859942/… — miken32
– miken32, Commented Oct 23, 2015 at 18:16
@miken32 Yes, you're right, but I have to use that awful and deprecated method because this is very old software and I've been instructed to do so! — Joe Cool
– Joe Cool, Commented Oct 27, 2015 at 16:50

Community · Accepted Answer · 2017-05-23 12:29:53Z

2

Add another parameter to the function.

Also, variables are only expanded inside double quotes, not single quotes. See What is the difference between single-quoted and double-quoted strings in PHP?

if ( !function_exists("testQuery") ) {
    function testQuery($id, $finished_size) {
        return "UPDATE master SET finished_size = '$finished_size' WHERE id = $id";
    }
}

$query = testQuery($id, $finished_size);

mysql_query ($query, $db);

edited May 23, 2017 at 12:29

CommunityBot

11 silver badge

answered Oct 22, 2015 at 20:28

Barmar

789k57 gold badges554 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Martin Heralecký · Accepted Answer · 2015-10-22 20:28:58Z

1

If you're putting a variable to a string without connecting more strings, you have to use quotes, not apostrophes. So:

return "UPDATE master SET finished_size = '$finished_size' WHERE id = $id";

answered Oct 22, 2015 at 20:28

Martin Heralecký

5,8194 gold badges32 silver badges68 bronze badges

Comments

Joe Cool · Accepted Answer · 2015-10-23 18:05:25Z

0

It turned out that the problem was that I was using $_POST variables, that had already been extracted, so that $finished_size was no longer treated as a global variable (like $_POST['finished_size'] would be). And so the extracted variable did not have scope access within the function.

So I just re-extracted $_POST inside the function. I had many $_POST variables coming in from a form, and so extracting them inside the function seems to be a fairly convenient way to pass them back to $query.

The answers that were given prior to this were helpful for me to realize that it was a scope issue.

answered Oct 23, 2015 at 18:05

Joe Cool

627 bronze badges

Collectives™ on Stack Overflow

passing return value from a php function to a mysql_query

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related