Fetch string arrays from json in angularjs controller

Question

I am trying to fetch string arrays from a json file and return the data back to a variable to form a word filer list, but "uncaught syntax error" kept showing can anyone help? Here comes my code:

    var filterWords = $http.get('word.json').success(function(res) {
      return angular.fromJson(res.data);
    });

    $scope.filterWord = function($string) {
         var wRegExp = new RegExp(filterWords.join("|"), "gi");
         return wRegExp.test($string);
    };

Thanks in advance!

There is no syntax error here. Some another part of your code causes an error. — hsz
– hsz, Commented Oct 22, 2015 at 7:21
plus, I am not sure that your code will work, you treat in the second function an async function as a sync function. — Meir
– Meir, Commented Oct 22, 2015 at 7:23
@Meir Does it mean that the data could be set to filterWords even after the filterWord() called? — Alexander Wang
– Alexander Wang, Commented Oct 22, 2015 at 7:36
It means that async calls usually set scope values (used by binding in the view) asynchronously — Meir
– Meir, Commented Oct 22, 2015 at 9:15

Steve Klösters · Accepted Answer · 2015-10-22 07:24:07Z

2

You don't have to do the angular.fromJson part, AngularJS does that for you. res.data will contain an object parsed from JSON if the result is JSON.

In the line var wRegExp = new RegExp(filterWords.join("|"), "gi"); you are not waiting for the result of filterWords, so you are calling join("|") on an HTTP promise. I'm not sure what the structure of your code is since I can only see the two lines you've shown, but perhaps you meant to set a variable in the success handler? Or have the success handler in the filterWord function?

answered Oct 22, 2015 at 7:24

Steve Klösters

9,4472 gold badges44 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Alexander Wang Over a year ago

I need the data in the json file and set them to filterWords for filterWord(). Maybe I should have the success handler in the filterWord function?

Steve Klösters Over a year ago

Then I would change the name of filterWords to filterWordsPromise and instead of returning something in the success handler I would do something like $scope.filterWord = res.data. Keep in mind that since the call is asynchronous, $scope.filterWord will be undefined for a while, then be set to the result.

Alexander Wang Over a year ago

Thanks a lot! So your idea is to define filterWord() as an asyn function while synchronized with $http.get right?

Collectives™ on Stack Overflow

Fetch string arrays from json in angularjs controller

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related