Sorting array in C using function, but program just doesn't run

Question

#include <stdio.h>
#include <conio.h>

void sorter(int b, int a[]);

int main(void){
    int i, j, arraySize;
    int arrayNums[arraySize];

    printf("Please enter how many numbers you wish to enter: ");
    scanf("%d", &arraySize);

    for(i =0; i<arraySize; i++)
    {
        printf("Enter Value No. %d: ", i+1);
        scanf("\n%d", &arrayNums[i]);
    }

    for(i=0; i<arraySize; i++)
    printf("%d", arrayNums[i]);

    sorter(arraySize,arrayNums);

    printf("after sorting");

    for(i=0; i<arraySize; i++)
    {
        printf("\n%d", arrayNums[i]);
    }
}

void sorter(int b, int a[]){
    int i,j, swap;

    for(i = 0; i<b; i++)
        for(j=i; j<b; j++)
        {
            if(a[i]>a[j]){
                swap= a[i];
                a[i]=a[j];
                a[j]=swap;
            }
        }
}

when I compile it in CodeBlocks, it gives:

Process terminated with status 0 (0 minute(s), 0 second(s))
0 error(s), 0 warning(s) (0 minute(s), 0 second(s))

and when I run the program, it just crashes.

Any clues?

Compile it with -Wall option. You will discover a lot of things... — LPs
– LPs, Commented Oct 19, 2015 at 10:27
whoops! previously arrayNums was declared after taking arraySize's value (when I was simply sorting the array without the function), don't know when and why I changed it. How did I nott notice this. sorry for wasting your time — Muhammad Nouman Panhwar
– Muhammad Nouman Panhwar, Commented Oct 19, 2015 at 10:30
You have to allocate dynamically, since you do not know the size of the array at compile time — m47h
– m47h, Commented Oct 19, 2015 at 11:10
can you please explain it?? @m47h, I mean what you want to say?? — Muhammad Nouman Panhwar
– Muhammad Nouman Panhwar, Commented Oct 19, 2015 at 14:33

SKD · Accepted Answer · 2015-10-19 10:30:02Z

2

The problem is :- you are using arraySize without initializing it.

I've just swaped two statements and it works fine.:-

     printf("Please enter how many numbers you wish to enter: ");
     scanf("%d", &arraySize);

     int arrayNums[arraySize];

answered Oct 19, 2015 at 10:30

SKD

4601 gold badge4 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Sorting array in C using function, but program just doesn't run

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related