Echo PHP Variable to Button Value Then Send Button Value to Input text

Question

Hello I am wanting to echo a PHP Variable to a buttons value then send the buttons value to an input text. I was able to echo the button with the variable but when I click the button it does nothing. I'm not sure why, because when I do this without the PHP just the script, and inputs it works perfectly. I am just missing something I know it, I can't find much info on how to pass php to a button then pass the button value to an input text.

Here's the script that passes the button value to the input text:

$( document ).ready(function() {
var $theButtons = $(".button");
var $theinput = $("#theinput");
$theButtons.click(function() {
    $theinput.val(this.value);
});
});

Here's the PHP that echos the variable as a button:

        require "config.php";  // database connection



    $in=$_GET['txt']; 
    if(!ctype_alnum($in)){  // 
    echo "Search By Name, or Entry ID";
    exit;
    }

    $msg="";
    $msg="";
    if(strlen($in)>0 and strlen($in) <20 ){ 
    $sql="select name, entry, displayid from item_template where name like '%$in%' LIMIT 10"; // the query
    foreach ($dbo->query($sql) as $nt) {
    //$msg.=$nt[name]."->$nt[id]<br>";
    $msg .="<table style='table-layout:fixed;'> // Just the start of my table
    <tr>
    <td>Name</td>
    <td>Entry ID</td>
    <td>Display ID</td>
    </tr>
    <tr>
    <td align=center><a href=http://wowhead.com/item=$nt[entry]>
    $nt[name]</a>
    </td>
    <td>$nt[entry]</td>
    <td>
    <input type=button class=button value=$nt[displayid]> // The Value I need echoed out in a button is $nt[displayid]
    </td>
    </tr>
    </table>"; // end of my table}
}
$msg .='';
echo $msg;

Not that it matters but here is the input text

<input type="text" id="theinput"/>

kindly fix the code, some block statements are not close properly — Oli Soproni B.
– Oli Soproni B., Commented Aug 13, 2015 at 1:14
This is the full php script? You never return/echo $msg and you haven't closed your if statements } — NewToJS
– NewToJS, Commented Aug 13, 2015 at 1:25
@JamieRoads I can only go by the source code you display. From what you were showing it was incorrect meaning it wouldn't do anything as you didn't attempt to output anything. Since you want to play smart to those willing to help you I wish you the very best of luck as I'm not going to bother. I believe many who read this will decide to help someone worth the time and your attitude doesn't seem to fit. — NewToJS
– NewToJS, Commented Aug 13, 2015 at 1:47
@JamieRoads I did quote that as I was pointing out something for the second time, just thought I would use your own word and quote them. Good luck getting help! I think you'll need it when people read the comments. Next time post the relevant source code and people will see you have no errors rather than getting this sort of attitude from someone asking for help. — NewToJS
– NewToJS, Commented Aug 13, 2015 at 1:49
Your HTML attributes should be quoted, especially when putting dynamic values into them — Phil
– Phil, Commented Aug 13, 2015 at 2:05

Blake · Accepted Answer · 2015-08-13 02:13:10Z

2

Make it easy on yourself and try to make your code easy to read. I personally prefer to write my html cleanly and outside of echo statements like so:

Html

if (strlen($in) > 0 and strlen($in) < 20) {
    $sql = "select name, entry, displayid from item_template where name like '%{$in}%' LIMIT 10"; // the query
    foreach ($dbo->query($sql) as $nt) {
        //$msg.=$nt[name]."->$nt[id]<br>";
        ?>
        <table style="table-layout:fixed;">
            <tr>
                <td>Name</td>
                <td>Entry ID</td>
                <td>Display ID</td>
            </tr>
            <tr>
                <td align="center">
                    <a href="http://wowhead.com/item=<?=$nt['entry'];?>"><?=$nt['name'];?></a>
                </td>
                <td><?=$nt['entry'];?></td>
                <td>
                    <input type="button" class="button" value="<?=$nt['displayid'];?>">
                </td>
            </tr>
        </table>
        <?php
    }
}

Javascript

$( document ).ready(function() {
    var $theButtons = $(".button");
    var $theinput = $("#theinput");
    $theButtons.click(function() {
        // $theinput is out of scope here unless you make it a global (remove 'var')
        // Okay, not out of scope, but I feel it is confusing unless you're using this specific selector more than once or twice.
        $("#theinput").val(jQuery(this).val());
    });
});

edited Aug 13, 2015 at 2:13

answered Aug 13, 2015 at 2:02

Blake

2,3241 gold badge16 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

23 Comments

Blake Over a year ago

In his anonymous function?

Blake Over a year ago

@JamieRoads You should be able to use my code copy/paste.

Phil Over a year ago

@JamieRoads and now we're back to the original argument in the comments above; you haven't provided all the relevant information :(

Blake Over a year ago

@JamieRoads Your original question doesn't mention anything about AJAX search results.

Blake Over a year ago

It is unknown if you have more php code under your snippet and I had to close your if and foreach loop for functional PHP code.

|

Phil · Accepted Answer · 2015-08-13 02:53:49Z

0

Ok, here goes...

Use event delegation in your JavaScript to handle the button clicks. This will work for all present and future buttons

jQuery(function($) {
    var $theInput = $('#theinput');
    $(document).on('click', '.button', function() {
        $theInput.val(this.value);
    });
});

Less important but I have no idea why you're producing a complete table for each record. I'd structure it like this...

// snip

if (strlen($in)>0 and strlen($in) <20 ) :
// you really should be using a prepared statement
$sql="select name, entry, displayid from item_template where name like '%$in%' LIMIT 10";
?>
<table style="table-layout:fixed;">
<thead>
<tr>
    <th>Name</th>
    <th>Entry ID</th>
    <th>Display ID</th>
</tr>
</thead>
<tbody>
<?php foreach ($dbo->query($sql) as $nt) : ?>
<tr>
    <td align="center">
        <a href="http://wowhead.com/?item=<?= htmlspecialchars($nt['entry']) ?>"><?= htmlspecialchars($nt['name']) ?></a>
    </td>
    <td><?= htmlspecialchars($nt['entry']) ?></td>
    <td>
        <button type="button" class="button" value="<?= htmlspecialchars($nt['displayid']) ?>"><?= htmlspecialchars($nt['displayid']) ?></button>
    </td>
</tr>
<?php endforeach ?>
</tbody>
</table>

<?php endif;

edited Aug 13, 2015 at 2:53

answered Aug 13, 2015 at 2:36

Phil

166k25 gold badges265 silver badges269 bronze badges

7 Comments

Jamie Roads Over a year ago

When I put this in my html file nothing shows up it's a blank page

Phil Over a year ago

@JamieRoads You may have missed a closing brace or something. I've update my answer to better show you where the code goes; just replace everything from the if(strlen(... line down

Jamie Roads Over a year ago

Hm just did and still the same. I really appreciate your time and help guys. Just want ya'll to know, oh and your patience of my lack of coding knowledge.

Phil Over a year ago

The exit; in your first if statement is causing the page to be unfinished, you have no </body> or </html> closing tags in the rendered output if there's no txt query variable

Jamie Roads Over a year ago

I don't see an exit; could it be something to do with UTF-8 encoding?

|

Collectives™ on Stack Overflow

Echo PHP Variable to Button Value Then Send Button Value to Input text

2 Answers 2

23 Comments

7 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

23 Comments

7 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related