insert values from array

Question

im using phpexcel to read my xls, i dont have problems with that, but when im trying to insert values in my database appear this on console "Array to string conversion".

code:

 $inputFileName = $_FILES['xls']['tmp_name'];
    $inputFileType = PHPExcel_IOFactory::identify($inputFileName);
    $objReader = PHPExcel_IOFactory::createReader($inputFileType);
    $objPHPExcel = $objReader->load($inputFileName);
    // ------------------ COMISIONES ------------------ //
    $sheet = $objPHPExcel->getSheet(2);
    $highestRow = $sheet->getHighestRow();
    $highestColumn = $sheet->getHighestColumn();
    for ($row = 1; $row <= $highestRow; $row++) {
        $rowData[] = $sheet->rangeToArray('A' . $row . ':' . $highestColumn . $row, NULL, TRUE, FALSE);            
        foreach ($rowData[0] as $var) {
          $sql = "INSERT INTO bd_comisiones (registro,clave,nombre,rfc,comision,iva,subtotal,retencion,neto,prestamos,neto_a_recibir) VALUES ('" . implode(",", $var) . "')";
          $sql_insert = $conexion->prepare($sql);
          $sql_insert->execute();
        }
    }

array:

Array
(
    [0] => Array
        (
            [0] => Array
                (
                    [0] => Registro
                    [1] => CLAVE
                    [2] => NOMBRE
                    [3] => RFC
                    [4] => COMISION
                    [5] => IVA
                    [6] => SUBTOTAL
                    [7] => RETENCION
                    [8] => NETO
                    [9] => PRESTAMOS
                    [10] => NETO_A_RECIBIR
                )

        )

On which position/line do you get the error? And shouldn't you put the contents of $var in single quotes? I mean like VALUES ('" . implode("','", $var) . "')";? — stefita
– stefita, Commented Jul 28, 2015 at 19:12

Jake Bathman · Accepted Answer · 2015-07-28 19:10:15Z

1

Looks like your implode function needs a slight rework.

If you have array('a','b','c') and you want that to be a string with quotes around each value, you need to revise this line:

$sql = "INSERT INTO bd_comisiones
  (registro,clave,nombre,rfc,comision,iva,subtotal,retencion,neto,prestamos,neto_a_recibir)
  VALUES ('" . implode(",", $var) . "')";

to be like this:

$sql = "INSERT INTO bd_comisiones
  (registro,clave,nombre,rfc,comision,iva,subtotal,retencion,neto,prestamos,neto_a_recibir)
  VALUES ('" . implode('","', $var) . "')";

This will put "," between each value, instead of just a comma.

If you're still troubleshooting it, try to echo $sql; to see the fully-formed SQL statement to make sure it looks okay.

answered Jul 28, 2015 at 19:10

Jake Bathman

1,2773 gold badges18 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Crumor Over a year ago

awesome, but now there is no value on my bd

Marc B · Accepted Answer · 2015-07-28 19:10:22Z

1

Which line is your error occuring on?

And beyond that, your query will be incorrect:

$sql = "INSERT ... VALUES ('" . implode(",", $var) . "')";
                                        ^^^

This would produce

INSERT ... VALUES ('Registro,CLAV,...,NETO_A_RECIBIR')

which is a SINGLE string value. You want

$sql = "INSERT ... VALUES ('" . implode("','", $var) . "')";
                                         ^-^

isntead, so each individual component gets its own '...' quote set, producing

INSERT ... VALUES ('Registro','CLAV',...,'NETO_A_RECIBIR')

answered Jul 28, 2015 at 19:10

Marc B

362k44 gold badges433 silver badges508 bronze badges

1 Comment

Crumor Over a year ago

line 72, at query line by the way

Samuele Colombo · Accepted Answer · 2015-07-28 19:12:41Z

0

I've never used PHP Excel but I think that the problem is in your insert statement: when you implode your array there are only two quotes!

Simply change your line with this:

$sql = "INSERT INTO bd_comisiones (registro,clave,nombre,rfc,comision,iva,subtotal,retencion,neto,prestamos,neto_a_recibir) VALUES ('" . implode("','", $var) . "')";

answered Jul 28, 2015 at 19:12

Samuele Colombo

6852 gold badges6 silver badges20 bronze badges

2 Comments

Crumor Over a year ago

yeah, totally works, but i don't have any values in my bd >.< just end the procces but do nothing

Samuele Colombo Over a year ago

I can only suggest you to dump your variables (first of all check $sqland try to execute that code directly on your db).

stefita · Accepted Answer · 2015-07-28 19:18:21Z

0

I thing you should put single quotes in the implode function like

VALUES ('" . implode("','", $var) . "')";

to get string like

VALUES ('A', 'B', 'C');

otherwise is just

VALUES ('A, B, C');

answered Jul 28, 2015 at 19:18

stefita

1,7932 gold badges20 silver badges35 bronze badges

Collectives™ on Stack Overflow

insert values from array

4 Answers 4

1 Comment

1 Comment

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

1 Comment

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related