How to avoid errors with unit testing a controller?

Question

I am trying to unit test a controller. This is my controller:

app.factory('myService', function ($q) {
    var callMe = function (user) {
        var pr = $q.defer();
        pr.resolve('Hello ' + user);
        return pr.promise;

        //$timeout(function(){
        //    pr.resolve('Hello ' + user);
        //    return pr.promise;
        //},4000);

    }
    return {callMe: callMe};
});



app.controller('myCtrl',function($scope,myService){
    $scope.callService = function(){
        $scope.callMeValue = myService.callMe('lo');
    }
})

This is my test:

beforeEach(
    inject(function (_$rootScope_, $controller, _myService_, _myServiceTimeout_,$q) {
    myService = _myService_;
    myServiceTimeout = _myServiceTimeout_;
    $scope = _$rootScope_.$new();

    ctrl = $controller('myCtrl', {
        $scope: $scope,
        someService: someServiceMock
    });

    someServiceMock.callMe.andReturn($q.when('Ted'));
}));


it('ctrl test', function () {
    $scope.callService();
    expect(myService.callMe).toHaveBeenCalled();
});

Here are the errors I am getting:

TypeError: someServiceMock.callMe.andReturn is not a function

and:

Error: Expected a spy, but got Function.

How can I fix this?

plunkr: http://plnkr.co/edit/EM1blTOlg5fw5wq6OFcr?p=preview

milanlempera · Accepted Answer · 2015-07-28 07:20:53Z

1

Your example contains several bugs.

If you use timeout in code, in test you must use $timeout.flush() (scope.$apply not enough)
$timeout is promise, you not need create own promise

$timeout is promise, you must return it

app.factory('myServiceTimeout', function ( $timeout) {
    var callMe = function (user) {
        return $timeout(function(){
            return 'Hello ' + user;
        },4000);

    }
    return {callMe: callMe};
});


it('test2',function(){
    var result;
    myServiceTimeout.callMe('Ruud').then(function(ret)
    {
        result = ret;
    });

    $timeout.flush()
    expect(result).toBe('Hello Ruud');
});

whole exemple: http://plnkr.co/edit/cqzTYwfs94Xqyz5MTxeE?p=preview

answered Jul 28, 2015 at 7:20

milanlempera

2,2631 gold badge17 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to avoid errors with unit testing a controller?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related