Access array variables outside for loop javascript

Question

i am trying to populate a table using datatables jquery library , the problem encountered is that only the last value is displayed ,the values are accessed by looping through data stored in json . Here is my code :-

for (var i = 0; i < json_parsed.Users.length; i++) {
    var user = json_parsed.Users[i];
    if (user.position == "GK") {
        goalkepeers = [{
            "playerID": user.playerID,
            "playerName": user.playerName,
        }];
    }
}



$('#myTable').dataTable({
    "aaData": goalkepeers,
    "aoColumns": [{
            "mDataProp": "playerID"
        }, {
            "mDataProp": "playerName"
        },

    ]
});

Everything works fine but only one data is displayed in my table , the array should be like this

goalkepeers = [{
    "playerID": player1ID,
    "playerName": player1Name,
}, 
{   
    "playerID": player2ID,
    "playerName": player2Name,
}];

Any help will be appreciated , Thanks again :-)

You should push into goalkeepers array, not reassign a new array at each step of the loop. — raina77ow
– raina77ow, Commented Jul 21, 2015 at 14:11
You keep reassigning goalkepeers(sic) to a new array on each iteration through the loop. Presumably you meant to create an array and push a new object into the array? — Matt Burland
– Matt Burland, Commented Jul 21, 2015 at 14:12
Try goalkepeers.push({"playerID": user.playerID,"playerName":user.playerName}) you are overwriting the array with each iteration. — DavidDomain
– DavidDomain, Commented Jul 21, 2015 at 14:14
ridiculous how many answers can't even use proper indentation. — Sebastian Nette
– Sebastian Nette, Commented Jul 21, 2015 at 14:18

Rohit Arora · Accepted Answer · 2015-07-21 14:14:05Z

2

Try this, Declare goalkeepers globally and then declare goalkeeper everytime in the loop and push it into goalkeepers array:

var goalkeepers = [];
for (var i = 0; i < json_parsed.Users.length; i++){  
             var user = json_parsed.Users[i];
             if(user.position=="GK"){
                var goalkeeper= {
                "playerID": user.playerID,
                 "playerName":user.playerName,
                     };
                goalkeepers.push(goalkeeper);
               }
}

answered Jul 21, 2015 at 14:14

Rohit Arora

2,2622 gold badges28 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

robertrutenge Over a year ago

Thanks a lot rohit, but i get an error in "aaData": goalkepeers, , it says Uncaught ReferenceError: goalkeepers is not defined. but i can see it being defined at line 1.

robertrutenge Over a year ago

Sorry , my bad , it worked :-) Thanks a lot , appreciate :-)

Rohit Arora Over a year ago

Glad to help! otherwise i was also about to post any other approach to achieve the same :) .

Amin Jafari · Accepted Answer · 2015-07-21 14:15:15Z

1

it happens because you're replacing the values:

var goalkepeers= [];
for (var i = 0; i < json_parsed.Users.length; i++){  
    var user = json_parsed.Users[i];
    if(user.position=="GK"){
        var obj={
            "playerID": user.playerID,
            "playerName":user.playerName,
            };
        goalkeepers.push(obj);
        }
    }

answered Jul 21, 2015 at 14:15

Amin Jafari

7,2153 gold badges21 silver badges44 bronze badges

2 Comments

robertrutenge Over a year ago

Thanks a lot Amin, but i get an error in "aaData": goalkepeers, , it says Uncaught ReferenceError: goalkeepers is not defined. but i can see it being defined at line 1.

robertrutenge Over a year ago

Sorry , my bad , it worked :-) Thanks a lot , appreciate :-)

Vanojx1 · Accepted Answer · 2015-07-21 14:16:31Z

0

define the array before the loop

goldkeepers= array();

then inside the loop just do

goalkepeers.push({
        "playerID": user.playerID,
        "playerName": user.playerName,
    });

in your code your array is overwritten by the next json_parsed.Users element every time so the final result is an array with just the last element

answered Jul 21, 2015 at 14:16

Vanojx1

5,5842 gold badges25 silver badges37 bronze badges

Collectives™ on Stack Overflow

Access array variables outside for loop javascript

3 Answers 3

3 Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related