Node.js HTTP WebServer Write after End error

Question

I am new to node.js and have been trying to setup just a basic server to start with.

I have the code below running and I get a "Write After End" error.

Socket.html is a basic html file that has a hello world string in the body. There is literally nothing else in that file. I have tried using the "ReadFileSync" method and that throws up a whole new set of errors that I don't fully understand.

I will appreciate any help on this. I am brand new to this so please go a little easy on me :) Thank you in advance!

I have verified that the path is correct, and that the buffer does have the data.

var http = require('http');
var url = require('url');
var fs = require('fs');

var server = http.createServer(function(request, response){
console.log('Connection');

var path = url.parse(request.url).pathname.substr(1);
path = "\\" + path;

switch(path){
    case '/':
        response.writeHead(200, {'Content-Type': 'text/html'});
        response.write('hello world');
        break;
    case '\\socket.html':
        //console.log(path);
        fs.readFile(__dirname + path, function(error, data){
            if(error){
                response.writeHead(404);
                response.write("This domain is missing");
            }
            else{
                console.log(data);
                response.writeHead(200, {"Content-Type": "text/html"});
                response.write(data,"utf8");
            }
        });
        break;
    default:
        response.writeHead(404);
        response.write("This domain is missing");
        break;
}

response.end();
});

server.listen(8001);

mkozicki · Accepted Answer · 2016-01-20 17:01:49Z

2

I think when you read from the FileSystem async, the response.end() method is called before response.write() I would suggest using the following code instead:

var http = require('http'); 
var url = require('url'); 
var fs = require('fs'); 
var server = http.createServer(function(request, response) {
    var path = url.parse(request.url).pathname.substr(1);
    path = "\\" + path; 
    switch(path) {
        case '/':
            response.writeHead(200, {'Content-Type': 'text/html'}); 
            response.write('hello world'); 
            response.end();
        break; 
        case '\\socket.html':
            fs.readFile(__dirname + path, function(error, data) { 
                if(error) {
                    response.writeHead(404); 
                    response.write("This domain is missing"); 
                } else {
                    response.writeHead(200, {"Content-Type": "text/html"});
                    response.write(data, "utf8"); 
                } 
                response.end();
            }); 
        break; 
        default: 
            response.writeHead(404); 
            response.write("This domain is missing"); 
            response.end();
        break;
    } 
});

edited Jan 20, 2016 at 17:01

mkozicki

6,9021 gold badge19 silver badges18 bronze badges

answered Jul 18, 2015 at 17:56

Luca Schimweg

7975 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Nikhil Raman Over a year ago

Thanks Luca! That fixed the problem I was having! I had a feeling it had to do with the async Fs.read, but since I'm new I wasn't sure how to deal with it.

Luca Schimweg Over a year ago

I'm happy that I could help you :)

Nikhil Raman Over a year ago

Hey @Luca ! I have run into another node problem. I am learning the ropes and I am not entirely sure why I am getting some errors. I have posted a new question at: stackoverflow.com/questions/31506271/… Could you maybe take a look and help me out there? Thanks in advance!

Collectives™ on Stack Overflow

Node.js HTTP WebServer Write after End error

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related