jQuery running code on input text box change

Question

The following code runs fine from the #input-lines-percent inputs and updates the values correctly. #input-curves-percent does run the code so the change seems to be working, but it's not updating the text boxes at all.

To see what I mean, type some text in the Straight lines % box and see how both text boxes update. However try this on the Curves % and there is no update. The code for both is almost identical, so I am not sure what is causing this difference.

$('#input-curves-percent').change(function(e){
    updatePercentGroupShape('curve');
});
$('#input-lines-percent').change(function(e){
    updatePercentGroupShape('line');
});
function updatePercentGroupShape(lastEdit){
    // Updates the percentage boxes for the shape type percents
    
    var curves = parseInt($('#input-curves-percent').val());
    var lines = parseInt($('#input-lines-percent').val());

    if(lastEdit.localeCompare('curve') == 0){
        
        if(curves < 0){
            curves == 0;
        }else if(curves > 100){
            curves = 100;
        }
        lines = 100 - curves;

    }
    if(lastEdit.localeCompare('line') == 0){
        
        if(lines < 0){
            lines == 0;
        }else if(lines > 100){
            lines = 100;
        }
        curves = 100 - lines;
    }
    $('#input-curves-percent').val(curves);
    $('#input-line-percent').val(lines);
}

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<div>
	<div>Curves %</div>
	<div><input type="text" id="input-curves-percent" value="0"></div>
</div>
<div>
	<div>Straight lines %</div>
	<div><input type="text" id="input-lines-percent" value="100"></div>
</div>

what is that lastEdit.localeCompare('curve') is doing?

Marikkani Chelladurai
– Marikkani Chelladurai

2015-07-15 07:41:09 +00:00
Commented Jul 15, 2015 at 7:41 — Marikkani Chelladurai
– Marikkani Chelladurai, Commented Jul 15, 2015 at 7:41

Nagaraj S · Accepted Answer · 2015-07-15 07:42:50Z

3

There's a typo in last js line, just replace

    $('#input-line-percent').val(lines);
                 ^^^

with

    $('#input-lines-percent').val(lines);

edited Jul 15, 2015 at 7:42

Nagaraj S

13.5k6 gold badges35 silver badges53 bronze badges

answered Jul 15, 2015 at 7:40

MazzCris

1,8301 gold badge14 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Suresh Lakku · Accepted Answer · 2015-07-15 07:46:58Z

2

There was a typo error in it.

 id="input-lines-percent"

and in script

$('#input-line-percent').val(lines);

answered Jul 15, 2015 at 7:46

Suresh Lakku

951 gold badge1 silver badge9 bronze badges

Collectives™ on Stack Overflow

jQuery running code on input text box change

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related