API built in express responds with empty array

Question

I have my application populating an array with names. I can log the array values and it is getting the values, but using postman to make a request on localhost:8888/api/messages my response says matches : [] with the empty array. Why is my array empty in the response if I do indeed populate it?

router.get('/messages', function(request, res) {

  var names = [];
  ctxioClient.accounts(ID).contacts().get({limit:250, sort_by: "count", sort_order: "desc"}, 
    function ( err, response) {
      if(err) throw err;

      console.log("getting responses...");
      var contacts = response.body;
      var matches = contacts.matches;


      for (var i = 0; i < matches.length; i++){
        names.push(matches[i].name);
        matches[i].email;
      }  

    res.json({matches : names});   
  });


});

async, async, async. All async results must be processed and used inside the async completion callback, not outside of it. — jfriend00
– jfriend00, Commented Jul 15, 2015 at 2:27

Dhiraj · Accepted Answer · 2015-07-15 02:34:17Z

2

This is because the response.json() executes before the ctxioclient.get() happens. Call response.json inside .get() instead. Something like this

router.get('/messages', function(request, response) { // <--- router response
  var names = [];
  ctxioClient.accounts(ID).contacts().get({ limit: 250,sort_by: "count",sort_order: "desc"},function(err, resp) { // <---- using resp
      if (err) throw err;
      console.log("getting responses...");
      var contacts = response.body; 
      var matches = contacts.matches;
      for (var i = 0; i < matches.length; i++) {
        names.push(matches[i].name);
        matches[i].email;
      }
      response.json({ matches: names }); // <--- router response
    });
});

edited Jul 15, 2015 at 2:34

answered Jul 15, 2015 at 2:26

Dhiraj

33.7k10 gold badges65 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

Rafa Over a year ago

I'm putting it where you stated, but I then get the error response.json has no method json

Dhiraj Over a year ago

the function inside .get also have the variable response. I just saw that. rename it to something else

Rafa Over a year ago

Ok actually i'm assuming this is because I pass two parameters in as response and it is trying with the ctxClient response and not the get reponse

Dhiraj Over a year ago

yes, true. Please check my updated answer. You'll see that the callback function for ctxioclient.get will have a parameter resp instead of response

Rafa Over a year ago

I fixed it, and now I get no error, but my array is still empty. I've updated my code to reflect my changes

|

Collectives™ on Stack Overflow

API built in express responds with empty array

1 Answer 1

9 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

9 Comments

Your Answer

Sign up or log in

Post as a guest

Related