Syntax error in INSERT STATEMENT from c# to Access DB

Question

 con.Open();
        cmd = new OleDbCommand("insert into login (user, password) values ('" +textBox1 .Text + "','" + textBox2 .Text + "');",con);
        cmd.CommandType = CommandType.Text;
        int temp = cmd.ExecuteNonQuery();
        if (temp > 0)
        {
           textBox1.Text = null;
            textBox2.Text = null;
            MessageBox.Show("Record Successfuly Added");
        }
        else
        {
            MessageBox.Show("Record Fail to Added");
        }
        con.Close();

when i try to insert some of error appear ( syntax error in INSERT STATEMENT ) i'm try different method to values like Parameters or direct plz !

I think it is because of the key words like Login , user and password, trying putting square brackets [] around them and execute the same query again. — M.Ali
– M.Ali, Commented Jul 1, 2015 at 23:47
Side Notes: 1) Use textBox1.Text = string.Empty instead of textBox1.Text = null. 2) You can close the connection right after query execution ( int temp = cmd.ExecuteNonQuery(); con.Close(); ). — Ahmad Ibrahim
– Ahmad Ibrahim, Commented Jul 1, 2015 at 23:52
its work now without any error, but when i open the database file i'm doesn't see any info. — M7off
– M7off, Commented Jul 2, 2015 at 0:26

meda · Accepted Answer · 2015-07-02 00:15:15Z

2

Escape reserved keyword user
use parameterized query
avoid sql injection
Make use of disposable objects

Try this approach:

using (OleDbConnection con = new OleDbConnection(connectionString))
{
    con.Open();
    using (var cmd = new SqlCommand(
    "insert into login ([user], [password]) values (@user, @pass);",
    con))
    {
        cmd.Parameters.Add(new OleDbParameter("@user", textBox1.Text ));
        cmd.Parameters.Add(new OleDbParameter("@pass", textBox1.Text ));

        if (temp > 0)
        {
            textBox1.Text = String.Empty;
            textBox2.Text = String.Empty;
            MessageBox.Show("Record Successfuly Added");
        }
        else
        {
            MessageBox.Show("Record Fail to Added");
        }
    }
}

answered Jul 2, 2015 at 0:15

meda

45.5k14 gold badges96 silver badges123 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

M7off Over a year ago

how can i do? i'm new user to this site

Collectives™ on Stack Overflow

Syntax error in INSERT STATEMENT from c# to Access DB

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related