bash script - unable to evaluate variable to string correctly

Question

Trying to debug my bash script. What's wrong with my syntax here? I'm trying to evaluate a parameter entered by the user and based on that run one of my IF-THEN statements. However, I'm getting a command not found.

Here's my script thus far:

if [[ $# != 4 ]]; then
   echo "Usage: ./test.sh <ABC|XYZ> <owner> <db> <TARGETHOST>" 2>&1
   exit 1
fi

case $1 in
    ABC|XYZ)
       filename="get-$1.sql"
       ;;
    *)echo "Must enter ABC or XYZ"
      exit 1
      ;;
esac

export OWNER=$2
export DB=$3
export HOST_NM=$4
export PORT=5432
export LOG="test-$1.log"
PSQL=`which psql`


if [[$1=="ABC"]]; then
      RUNCLI=$("$PSQL" -h $HOST_NM -p $PORT -U $OWNER $DB -F $'\t' --no-align -f get-$1.sql | tee >> $LOG)
      exit 1
   else
      echo "Error running report ..."
fi

if [[$1=="XYZ"]]; then
      RUNCLI2=$("$PSQL" -h $HOST_NM -p $PORT -U $OWNER $DB -a -f get-$1.sql | tee >> $LOG)
      exit 1
   else
      echo "Error running report ..."
fi

Error:

./test.sh: line 41: [[XYZ==ABC]]: command not found
Error running report ...
./test.sh: line 51: [[XYZ==XYZ]]: command not found
Error running report ...

There should be a space after [[, before ]] and probably around the operator. — ShellFish
– ShellFish, Commented Jun 22, 2015 at 22:53
If your intent is to write your error message to stderr, then 2>&1 should be 1>&2 — David C. Rankin
– David C. Rankin, Commented Jun 23, 2015 at 1:15

Rambo Ramon · Accepted Answer · 2015-06-22 23:14:41Z

1

Although the question is already answered in the comment section I want to give an answer and share some knowledge which is not obvious (at least it was not for me).

The if in bash just checks the return code of the following command, which means that instead of if [ condition ]... or if [[ condition ]]... you could also write if ./configure && make.... [ and [[ are commands or shell-built-ins, respectively, as well and not part of the if syntax. An which [ for instance returns /bin/[. At this point it is obvious that you need spaces between the brackets and the condition since it is just just a set of parameters passed to a command.

If you have this in mind, you will never forget the spaces again.

answered Jun 22, 2015 at 23:14

Rambo Ramon

1,0347 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

bash script - unable to evaluate variable to string correctly

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related