combining data/variables jquery

Question

var student = [{
    "fname": "Jackie",
    "mname": "Lee",
    "lname": "Li"
}, {
    "fname": "Ken",
    "mname": "Ryu",
    "lname": "Sha"
}];

for (var i = 0; i < student.length; i++) {
    console.log(student[i].fname + " " + student[i].mname + ". " + student[i].lname ? student[i].fname + " " + student[i].mname + ". " + student[i].lname + " , " : " ");
}

I am trying to combine names in the a td these names are from an array. I was able to make the names combine by above code. problem is on the last name there is still a , just want to get rid of the comma when there are no more names that will follow. I am bugged by this simple comma for hours. any idea is appreaciate.

FIDDLE

console.log(student[i].fname + " " + student[i].mname + ". " + student[i].lname + ((i < student.length -1) ? ", " : " ")); — Markai
– Markai, Commented Jun 11, 2015 at 11:09
I do just want to mention that the use of tertiary operator in this piece of code is ill-advised. It makes this string of code illegible. Rather spread out over multiple lines and store in a variable than using this many nested operators. — somethinghere
– somethinghere, Commented Jun 11, 2015 at 11:14
@Pekka I am pointing at your original code's use of the tertiary operator. Its recommended to not use it in the middle of a string concatenation as it looks really confusing. Try to separate everything out in steps first - create a variable to store your string, add the first thing, then add the next, then use a tertiary operator to add one more etc... Then log the string stored in the variable. Do all these on separate lines with the += operator. It will make your code easier to parse, errors easier to spot, and solutions easier to find. — somethinghere
– somethinghere, Commented Jun 11, 2015 at 11:25

T.J. Crowder · Accepted Answer · 2015-06-11 11:10:54Z

One easy way is to build up an array and then using .join(", "):

var student = [{
  "fname": "Jackie",
  "mname": "Lee",
  "lname": "Li"
}, {
  "fname": "Ken",
  "mname": "Ryu",
  "lname": "Sha"
}];

var names = [];
for (var i = 0; i < student.length; i++) {
  names.push(student[i].fname + " " + student[i].mname + ". " + student[i].lname);
}
snippet.log(names.join(", "));

<!-- Script provides the `snippet` object, see http://meta.stackexchange.com/a/242144/134069 -->
<script src="http://tjcrowder.github.io/simple-snippets-console/snippet.js"></script>

It can even be more concise with Array#map:

var student = [{
  "fname": "Jackie",
  "mname": "Lee",
  "lname": "Li"
}, {
  "fname": "Ken",
  "mname": "Ryu",
  "lname": "Sha"
}];

snippet.log(student.map(function(entry) {
  return entry.fname + " " + entry.mname + ". " + entry.lname;
}).join(", "));

<!-- Script provides the `snippet` object, see http://meta.stackexchange.com/a/242144/134069 -->
<script src="http://tjcrowder.github.io/simple-snippets-console/snippet.js"></script>

Tharindu Kumara · Accepted Answer · 2015-06-11 11:31:16Z

3

Try this bit of code

var student = [{
  "fname": "Jackie",
  "mname": "Lee",
  "lname": "Li"
}, {
  "fname": "Ken",
  "mname": "Ryu",
  "lname": "Sha"
}]

for (var i = 0; i < student.length; i++) {
  var out = student[i].fname + " " + student[i].mname + ". " + student[i].lname;
  if (i < student.length - 1) {
    out += ", ";
  } else {
    out += " ";
  }
  snippet.log(out);
}

<!-- Script provides the `snippet` object, see http://meta.stackexchange.com/a/242144/134069 -->
<script src="http://tjcrowder.github.io/simple-snippets-console/snippet.js"></script>

edited Jun 11, 2015 at 11:31

answered Jun 11, 2015 at 11:12

Tharindu Kumara

4,4882 gold badges31 silver badges46 bronze badges

1 Comment

cezar Over a year ago

This answer has already been given. The drawback is the readability. The ternary operator in the statement obfuscates the code a little bit.

Josh Crozier · Accepted Answer · 2015-12-10 23:27:11Z

3

If I understand your question right than this should do it:

for(var i = 0 ; i < student.length; i++){
  var name = student[i].fname + " " + student[i].mname + ". " + student[i].lname ?  student[i].fname + " " + student[i].mname + ". " + student[i].lname: " ";
  if (i < (student.length - 1)) {
      name += ',';
  }
}

edited Dec 10, 2015 at 23:27

Josh Crozier

242k56 gold badges401 silver badges316 bronze badges

answered Jun 11, 2015 at 11:11

Sebastian Hens

1579 bronze badges

Comments

Alex Filatov · Accepted Answer · 2015-06-11 11:10:13Z

2

Try this jsfiddle

you should use like this:

var student = [{
     "fname": "Jackie",
         "mname": "Lee",
         "lname": "Li"
 }, {
     "fname": "Ken",
         "mname": "Ryu",
         "lname": "Sha"
 }]

 for (var i = 0; i < student.length; i++) {
     console.log(student[i].fname + " " + student[i].mname + ". " + student[i].lname + ((i < student.length - 1) ? ", " : " "));
 }

answered Jun 11, 2015 at 11:10

Alex Filatov

2,3693 gold badges33 silver badges47 bronze badges

Collectives™ on Stack Overflow

combining data/variables jquery

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related