PHP iterating through array returned from a function

Question

Hi I have a class file which contains a function to retrieve users from a mySQL database. The code is as following :

class userdbase
{
    public function fetchUsers()
    {
        $db = new mysqli('localhost', 'user', 'pass', 'dbase');

        if($db->connect_errno > 0)
        {
            die('Unable to connect to database [' . $db->connect_error . ']');
        }

        $sql = "SELECT username from `users`";

       if(!$result = $db->query($sql))
       {
           die('There was an error running the query [' . $db->error . ']');
       }

       while($row = $result->fetch_assoc())
       {
           $users[] = $row['username'];
       }
       $result->free();
       $db->close();
       return array($users);
    }
}

The code above returns an array as following using print_r($dbase->fetchUsers()) :

Array
(
[0] => Array
    (
        [0] => user1
        [1] => user2
        [2] => user3

        )

)

I am having trouble looping through the array from the main file where i reference to the function in the class . The code i am using is as following :

<?php

require("dbase.php");

$dbase = new userdbase();

 foreach($dbase->fetchUsers() as $result)  //this doesn't work
 {
    print "$result"; 
 }
?>

Can someone more versed in PHP point me out the correct way to do this ? Thanks in advance !

return array($users); returning it with another nesting is superfluous. return $users; should suffice — Kevin
– Kevin, Commented Jun 4, 2015 at 6:14
Thanks Ghost, I overlooked that and it solved the issue as well. — datether
– datether, Commented Jun 4, 2015 at 6:19

Nicholas Alexander · Accepted Answer · 2015-06-04 06:17:32Z

1

When you build the array of users[] here:

while($row = $result->fetch_assoc())
{
    $users[] = $row['username'];
}

$users is an array, but when you return it, wrapping it in array() means you are returning an array of arrays which is not what you then process.

Solution is just return $users.

answered Jun 4, 2015 at 6:17

Nicholas Alexander

3492 silver badges7 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Narendrasingh Sisodia · Accepted Answer · 2015-06-04 06:20:43Z

1

Instead of

return array($users);

only return

return $users;

and simply apply your foreach loop

answered Jun 4, 2015 at 6:20

Narendrasingh Sisodia

21.4k6 gold badges51 silver badges54 bronze badges

Collectives™ on Stack Overflow

PHP iterating through array returned from a function

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related