Issue with string array

Question

The below code gives result as test:[someproduct, someproduct, someproduct, someproduct, someproduct]. I am expecting result as ["someproduct", "someproduct", "someproduct", "someproduct", "someproduct"] so that I will push the string array into json response

String[] Id = new String[5];
for (int i = 0; i < 5; i++) {
    Id[i] ="someproduct";
}
System.out.println("test:"+Arrays.toString(Id));
writer.key("product").value(Arrays.toString(Id));

When I try access the jsonresponse like response.product[0], i am getting first character '[' alone. I suppose to get first item(someproduct) of the array.

Please help me to resolve.

If Arrays.toString(Id) doesn't produce the output you desire, simply loop over the array and build that output yourself. — Eran
– Eran, Commented May 21, 2015 at 12:30
It's unclear what writer is, but does writer.key("product").value(Id); give the output you seek? — Elliott Frisch
– Elliott Frisch, Commented May 21, 2015 at 12:32
sorry, i am expecting result as ["someproduct", "someproduct", "someproduct", "someproduct", "someproduct"] so that I can call res[0], res[1] etc. Can anyone help me write regular expression on this? — ezhil
– ezhil, Commented May 21, 2015 at 13:14
You expect that result when you print it out to screen? How do you print it? — aioobe
– aioobe, Commented May 22, 2015 at 5:09

nafas · Accepted Answer · 2015-05-22 16:23:57Z

2

the problem is the method you are using is not sufficient. one way of doing this, is to use another type of array (e.g. ArrayList) then Override its toString method.

here is an example:

 public static void main(String... args) throws Exception{
    ArrayList<String> array=new ArrayList<String>(){

        /**
         * 
         */
        private static final long serialVersionUID = 1L;

        @Override
        public String toString(){
            StringBuilder sb = new StringBuilder();
            sb.append("[");
            boolean isFirst=true;
            for(String s : this){
                if(!isFirst){
                    sb.append(",");
                }
                isFirst=false;
                sb.append("\""+s+"\"");
            }
            sb.append("]");
            return sb.toString();
        }
    };


    for (int i = 0; i < 5; i++) {
      array.add("someproduct");
    }
    System.out.println(array);


}

output:

["someproduct","someproduct","someproduct","someproduct","someproduct"]

NOTE:

There are many ways to make this code reusable, e.g.

creating a new class ArrayListWithNicePrint that extends ArrayList
creating a static method that returns you a fresh ArrayList with nice Print (I prefer this one really)

EDIT: (Based ON comment):

public class ArrayListWithNicePrint<E> extends ArrayList{


        @Override
        public String toString(){
            StringBuilder sb = new StringBuilder();
            sb.append("[");
            boolean isFirst=true;
            for(Object s : this){
                if(!isFirst){
                    sb.append(",");
                }
                isFirst=false;
                sb.append("\""+s.toString()+"\"");
            }
            sb.append("]");
            return sb.toString();
        }

    }

Testing:

public class Testing{
   public static void main(String... args){

   ArrayListWithNicePrint<String> list= new ArrayListWithNicePrint<String>();
   list.add("hi");
   list.add("hello");
   System.out.println(list);
   }
}

edited May 22, 2015 at 16:23

answered May 21, 2015 at 12:41

nafas

5,4533 gold badges34 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

ezhil Over a year ago

thanks, we can do it by overriding toString method !

ezhil Over a year ago

As you ve suggested to create new class ArrayListWithNicePrint that extends ArrayList. can you please give me some example for the this.

ezhil Over a year ago

thanks for your response Nafas. I have tried above the code, have added public static void main but it returns me "[someproduct, someproduct, someproduct, someproduct, someproduct]" without having double quotes. It seems toString() method is not called. Am I missing anything?

nafas Over a year ago

@ezhil I think you made a mistake on the initializations. I've added a test class and made the ArrayListWithNicePrint public to make it easier accessible.

ezhil Over a year ago

thanks Nafas, it is working fine.there was some problem while initialization. once again thanks a lot :)

brso05 · Accepted Answer · 2015-05-21 12:33:41Z

1

Try this :

String[] Id = new String[5];

for(int i = 0; i < 5; i++) 
 {

   Id[i] =" **\"someproduct\"** ";

 }

hope it will work

edited May 21, 2015 at 12:33

brso05

13.3k2 gold badges25 silver badges41 bronze badges

answered May 21, 2015 at 12:33

Ankush

1421 silver badge11 bronze badges

1 Comment

Ankush Over a year ago

Id[i] =" \"someproduct\" ";

Fernando Garcia · Accepted Answer · 2015-05-21 12:35:12Z

1

You can use some JSON converter library, or as a quickfix you could use something like this:

String[] Id = new String[5];
for (int i = 0; i < 5; i++) {
    Id[i] ="\"someproduct\"";
}
String arrOutput = Arrays.toString(Id).replaceAll("\\[", "{").replaceAll("\\]", "}");
System.out.println("test:"+ arrOutput);
writer.key("product").value(arrOutput);

Depending on the content on your array elements more workaround would be needed. Maybe if you write more information we can help you better.

answered May 21, 2015 at 12:35

Fernando Garcia

1,9992 gold badges13 silver badges14 bronze badges

Comments

sapamlucy · Accepted Answer · 2015-05-21 12:40:38Z

1

why dont u try putting it into a List and then use Gson to convert the whole list into json format, dig a bit to get the correct format of json u want. for retrieving u can retrieve easily with the tag names associated with each element. What u require is not very clear so this is the best guess i can make

answered May 21, 2015 at 12:40

sapamlucy

3061 gold badge3 silver badges15 bronze badges

Comments

Anil Reddy Yarragonda · Accepted Answer · 2015-05-21 12:55:29Z

1

Try with this code. it will resolve your issue.

    String[] Id = new String[5];
        for (int i = 0; i < 5; i++) {
            Id[i] ="\"someproduct\"";
        }
        System.out.println("test:"+Arrays.toString(Id).replace('[', '{').replace(']', '}'));

edited May 21, 2015 at 12:55

answered May 21, 2015 at 12:41

Anil Reddy Yarragonda

7675 silver badges20 bronze badges

2 Comments

Fernando Garcia Over a year ago

Is similar to my answer. OP wants that the elements are inside quotes ", as well.

ezhil Over a year ago

Hi, i am expecting result as ["someproduct", "someproduct", "someproduct", "someproduct", "someproduct"]. how do we write regular express for this? pls help

zutnop · Accepted Answer · 2015-05-21 12:42:11Z

0

When usin the JSONWriter object, you should use the built in array() and endArray() methods like this:

writer.key("product").array();
for (int i=0; i<5; i++) {
  writer.object();
  writer.key("name").value("someproductname" + i);
  writer.endObject();
}
writer.endArray();

http://www.json.org/javadoc/org/json/JSONWriter.html

answered May 21, 2015 at 12:42

zutnop

6215 silver badges7 bronze badges

Collectives™ on Stack Overflow

Issue with string array

6 Answers 6

5 Comments

1 Comment

Comments

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

5 Comments

1 Comment

Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related