angular js validate JSON from server

Question

as I understand it Angular http has 2 checks 'success and 'error'. Thats in terms of connecting to the service or not - so I have that in hand and thats my first check.

The issue I have is that the data in my JSON has a success state which informs me if the data it contains or has received from my form had any problems with it, in which case there will be an error object that I act on and display to the user.

I need to check for that value of success, but where is the best place to check for that?

Should I be doing it in the controller?

Without that data being correct theres nothing else for the page to do so it is effectively the first thing that needs to be done after the data is retrieved.

heres the basic controller layout

 app.controller("dataCtrl", function ($scope, $http) {

$http.post('/getdata').success(function (data) {

    $scope.businessData = data;

    // Should I then be checking businessData.success at this level?

}).error(function () {
    alert("Problem");
});

});

If your response header has one of many error statuses, the flow will switch to error block automatically. You don't have to check for success or failure if your API responds with errors properly. — Yaro Holodiuk
– Yaro Holodiuk, Commented May 12, 2015 at 14:39
This is going to end up being developer preference, but the question is what operations should happen in your controller vs in your service vs in your API. In my opinion, it should happen in a service as that is where business logic should be, your controller is for binding data to your view and shouldn't handle lots of logic. — bamblack
– bamblack, Commented May 12, 2015 at 14:39
Yes you can check it in the success callback and perform your action as per the result!!!! — Alhuck
– Alhuck, Commented May 12, 2015 at 14:44

Ralf de Kleine · Accepted Answer · 2015-05-12 15:03:28Z

1

You can write something like this:

$http.post('/getdata').success(function (data) {
  if (validate(data)) {
    $scope.businessData = data;
  } else {
    $scop.buisnessDataError = {msg: 'smth bad happend'};
  }
}).error(function () {..})

Otherwise, you can write your validator in Promise-like style and then just chain promises in such manner:

$http.post('/getdata').then(function (res) {
   return validator(null, res.data);
}, function (err) { 
   return validator({msg: 'error'})
}).then(function (data) {
   //proceed your data
}, function (err) {
  alert(err.msg);
});

Where validator is:

var varlidator = function (err, data) {
  return $q(function (resolve, reject) {
   if (/*data is not valid*/ || err) {
     reject(err);
   } else {
     resolve(data);
   }
  });
}

$q is a standard angulars implementation of Promises

edited May 12, 2015 at 15:03

Ralf de Kleine

11.8k5 gold badges50 silver badges89 bronze badges

answered May 12, 2015 at 15:00

Anton Savchenko

1,3201 gold badge8 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3779703 Over a year ago

Thanks, I will try option 1 at the moment as it seems less code for a simple check.

Collectives™ on Stack Overflow

angular js validate JSON from server

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related