PHP MYSQL Endless Loop

Question

I have a problem with my php/mysql script. It should only output the while loop once but I am getting unlimited loops and an endless page.

$query = mysql_query("SELECT * FROM users WHERE username ='".base64_encode($_SESSION['username'])."' LIMIT 1"); 
$result = mysql_fetch_array($query);
   if(empty($result)){
      echo "No user... Error";
   }else{
   while($row = $result){
   ?>
<a href="index.php?user=<?=$row['id']?>"><?=base64_decode($row['username'])?></a> | <a  href="javascript:void(0);" id="logout">Logout</a>
   <?php
   }
}

I have tried a similar script with these same lines and it works perfectly

  $result = mysql_fetch_array($query);
   if(empty($result)){
      echo "No user... Error";
   }else{
   while($row = $result){
      //Something
   }
}

loop http://img249.imageshack.us/img249/70/endlessloop.png

Bob Fincheimer · Accepted Answer · 2010-06-10 11:41:56Z

2

Look at:

http://php.net/manual/en/function.mysql-fetch-array.php

It has in the example:

$result = mysql_query("SELECT id, name FROM mytable");

while ($row = mysql_fetch_array($result)) {
    printf("ID: %s  Name: %s", $row[0], $row[1]);  
}

mysql_fetch_array gets an array of the next row OR false if there is none left.

$row = $result will create a infinite loop when $result is anything that doesn't cast to false

ADDITIONALLY

you can use mysql_num_rows [ http://php.net/manual/en/function.mysql-num-rows.php ] to check to see if zero results were returned:

$result = mysql_query("SELECT id, name FROM mytable");

if(mysql_num_rows($result) {
    while ($row = mysql_fetch_array($result)) {
        printf("ID: %s  Name: %s", $row[0], $row[1]);  
    }
} else {
    // NO ROWS RETURNED
}

answered Jun 10, 2010 at 11:41

Bob Fincheimer

18.1k1 gold badge31 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pekka · Accepted Answer · 2010-06-10 11:41:59Z

0

$row = $result is not a comparison but an assignment, and will always be true.

You need to put mysql_fetch_array into your while loop.

while($row = mysql_fetch_array($query)){
   ?>
<a href="index.php?user=<?=$row['id']?>"><?=base64_decode($row['username'])?></a> | <a  href="javascript:void(0);" id="logout">Logout</a>
   <?php
   }

answered Jun 10, 2010 at 11:41

Pekka

451k150 gold badges989 silver badges1.1k bronze badges

2 Comments

nebkat Over a year ago

But then I have to do two mysql_fetch_array($query) if I want to make a check for empty request?

Pekka Over a year ago

@Neb if you want to check for an empty result, use if (mysql_num_rows($query) == 0)

Collectives™ on Stack Overflow

PHP MYSQL Endless Loop

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related