Spring MVC controller doesn't return immediately when calling @Async method

Question

I'm using spring annotations for configuring Controllers(@EnableWebMvc), services(@service and @ComponentScan). In one of my services I have a method annotated with @Async and I also have @EnableAsync added on my config class. When one of MVC controller calls the service method which is annotated with @Async I expect the controller to return immediately without waiting for the service method to complete. By it does not. When I setup the break point in the service method I see that it is in fact running in a seperate thread i.e. the stacktrace does show that it is using SimpleAsyncTaskExecutor as I configured below.

Here is the annotation in my configuration class looks like

@Configuration
@EnableWebMvc
@EnableScheduling
@ComponentScan(basePackages = "com.mypackage")
@EnableAsync
public class WebApplicationConfig extends WebMvcConfigurerAdapter implements AsyncConfigurer {
...
...
@Override
    public Executor getAsyncExecutor() {
        SimpleAsyncTaskExecutor executor = new SimpleAsyncTaskExecutor("SimpleExecutor-");
        executor.setConcurrencyLimit(props.getIntegerProperty(SysProps.EMAIL_SENDER_CONCURRENT_THREAD_LIMIT));
        return executor;
    }

And here is my MVC controller method looks like

    @Autowired 
    private EmailService emailService;
    @ResponseStatus(value = HttpStatus.CREATED)
    @RequestMapping(value = "/asset/{assetId}/slideshare/email", method = RequestMethod.POST, produces = JSON_UTF8)
    @ResponseBody
    @ApiResponseObject
    public Link createAndEmailSlideShareLink(@PathVariable final String assetId,
                                             @RequestParam(value = "email") final String email,
                                             @RequestParam(value = "message", required = false) final String message,
                                             final HttpServletRequest request) {
    Link link = linkService.createLink()
    emailService.sendSlideShareAssetEmail(user,link...
    return link;
}

And the service method looks like this

@Async
public void sendSlideShareAssetEmail(User user, String email, String msg, String link, Asset asset) {

Why doesn't the MVC controller does not return immediately?

@chrylis I updated the post with the code from the controller class. Please check — Srini Kandula
– Srini Kandula, Commented May 7, 2015 at 22:33
You didn't actually post the content of the controller method. — chrylis -cautiouslyoptimistic-
– chrylis -cautiouslyoptimistic-, Commented May 8, 2015 at 0:38
The primary thing I was looking for was how you were constructing the return value, which does appear to be independent of the async call. — chrylis -cautiouslyoptimistic-
– chrylis -cautiouslyoptimistic-, Commented May 8, 2015 at 1:33
I think i know the problem but before i provide answer can you please show me your code where you extend AbstractAnnotationConfigDispatcherServletInitializer so i can confirm. — Aeseir
– Aeseir, Commented May 8, 2015 at 3:58

Ryan · Accepted Answer · 2015-07-16 20:07:37Z

0

My guess is that your EmailService bean is being included from two different contexts.

This answer from Ryan Stewart explains the problem/solution in more detail.

Do you have other configurations that are being used? Is there a *-servlet.xml or other servlets defined in your web.xml that might bring your EmailService into the root context?

Do you have a ContextLoaderListener or ServletContextListener defined? Perhaps those are picking up your EmailService in addition to the component scan.

Including your entire source tree as the component-scan path seems suspicious. Try restricting the paths you use in your component scan to exclude your EmailService and see if its still running executing in a SimpleAsyncTaskExecutor. If it is than you know its being brought in from a different context. Once you find the other context you should be able to exclude it there and add it back to your component-scan or EnableAsync in the other context.

edited Jul 16, 2015 at 20:07

answered Jul 16, 2015 at 18:43

Ryan

2,10117 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Artjom B. Over a year ago

Can you provide a short description of the solution? Otherwise this is only a comment and not an answer.

Collectives™ on Stack Overflow

Spring MVC controller doesn't return immediately when calling @Async method

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related