form validation in asp.net mvc ( using javascript )

Question

i'm new to asp.net mvc and i have aform with some validation and i want to validate it in client side so i write normal script in javascript to be more specefic my problem was the return false ( as it shouldn't send any data to server and still in apage but this doesn't happen) ,note : i test the script in normal html file with js and works fine but as i said i'm not familiar with mvc so i want to know if there any thing i have missed to work in it and if there any reference to any toturial in this specefic point it would be good , as i noticed in this place ( there's no place for beginners :); this is a snippet of my code too

@model registerationex.Models.register

@{
    ViewBag.Title = "Create";
}


<h2>Create</h2>

@using (Html.BeginForm()) {
    @Html.ValidationSummary(false)

    <fieldset>
        <legend>register</legend>

        <div class="editor-label">
            @Html.LabelFor(model => model.name)
        </div>

        <div class="editor-field">
            @Html.EditorFor(model => model.name)
            <span id="error"></span>
            @Html.ValidationMessageFor(model => model.name)
        </div>

        <div class="editor-label">
            @Html.LabelFor(model => model.email)
        </div>

        <div class="editor-field">
<input class="text-box single-line" data-val="true" data-val-required="The email field is required." id="email" name="email" type="text" value="" onblur="checkuser(email);">      
                  <span id="erroruser"></span>
            @Html.ValidationMessageFor(model => model.email)
        </div>

        <div class="editor-label">
            @Html.LabelFor(model => model.age)
        </div>
        <div class="editor-field">
            @Html.EditorFor(model => model.age)
            <span id="errorage"></span>
            @Html.ValidationMessageFor(model => model.age)
        </div>

        <p>
            <input type="submit" value="Create" onclick="allvalidate();"  />
        </p>
    </fieldset>
}

<div>
    @Html.ActionLink("Back to List", "Index")
</div>



@section Scripts {
    @Scripts.Render("~/bundles/jqueryval")

}

<script>
    function allvalidate() {
        var validated = true;
        if (!validate()) validated = false;
        if (!checkAge(age)) validated = false;
        if (!checkuser(email)) validated = false;

        return validated;
    }


    function validate() {
        var txtf = document.getElementById('name');
        if (txtf.value == 0 || txtf.value == null) {
            document.getElementById('error').innerText = ('you must enter firstname');
            document.getElementById('error').style.color = 'red';

            txtf.focus();
            return false;
        }
        else {
            document.getElementById('error').innerText = ('');
            return true;
        }
    }


    function checkAge(input) {
        if (input.value < 18 || input.value > 70) {
            document.getElementById('errorage').innerText = ('age must be from 18 :70');
            document.getElementById('errorage').style.color = 'red';
            return false;
        }
        else {
            document.getElementById('errorage').innerText = ('');
            return true;
        }

    }


    function checkuser(input) {
        var pattern = '^[a-zA-Z]+$';
        if (input.value.match(pattern)) {
            document.getElementById('erroruser').innerText = '';
            return true;
        }
        else {
            document.getElementById('erroruser').innerText = ('enter valid email');
            document.getElementById('erroruser').style.color = 'red';

            return false;
        }


    }



</script>

user3559349 · Accepted Answer · 2015-05-07 02:53:16Z

3

You have included @Scripts.Render("~/bundles/jqueryval") which by default jquery.validate.unobtrusive.js, so delete all your scripts and make use of the features which come with MVC. Simply add the validation attributes to your properties.

[Required(ErrorMessage = "you must enter firstname")]
public string name { get; set; }

[EmailAddress(ErrorMessage = "enter valid email")]
public string email { get; set; }

[Required(ErrorMessage = "you must your age")]
[Range(18, 70, ErrorMessage = "age must be from 18 : 70")]
public int age { get; set; }

Now everything that your scripts are trying to do (badly) is done out of the box (assuming you have not disabled unobtrusive validation) and the form will not submit until the errors are corrected. You also now get server side validation which is the essential validation (client side validation is just a nice bonus, but anyone can easily by pass it) so you must always validate on the server

Also replace you manual attempt to create an input for the email property with @Html.EditorFor(m => m.email) and remove all the onclick attibutes

Side note: you regex ^[a-zA-Z]+$ wont even allow a valid email address to be entered (it does not even allow the @ or . characters!). Using the EmailAddress] attribute will generate the correct regex which is (from jQuery Validation 1.9.0)

^((([a-z]|\d|[!#\$%&'\*\+\-\/=\?\^_`{\|}~]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+(\.([a-z]|\d|[!#\$%&'\*\+\-\/=\?\^_`{\|}~]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+)*)|((\x22)((((\x20|\x09)*(\x0d\x0a))?(\x20|\x09)+)?(([\x01-\x08\x0b\x0c\x0e-\x1f\x7f]|\x21|[\x23-\x5b]|[\x5d-\x7e]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(\\([\x01-\x09\x0b\x0c\x0d-\x7f]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF]))))*(((\x20|\x09)*(\x0d\x0a))?(\x20|\x09)+)?(\x22)))@((([a-z]|\d|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(([a-z]|\d|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])([a-z]|\d|-|\.|_|~|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])*([a-z]|\d|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])))\.)+(([a-z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(([a-z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])([a-z]|\d|-|\.|_|~|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])*([a-z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])))$

answered May 7, 2015 at 2:53

user3559349

Sign up to request clarification or add additional context in comments.

3 Comments

user4833581 Over a year ago

thanks for your answer and bounces too , i just want to know something from you . i know that the server validation is not an optional so i want to add a client side besides it to increase the performance by decrease the connect with server so if i used the mvc attributes in model ( is this validation work in server or in client) and thanks for email pattern notice ,note this is just atask to know about validation and i want to write simple pattern to accept words only and named it as email only @Stephen Muecke

user3559349 Over a year ago

Firstly if you have included the necessary scripts (jquery-{version}.js, jquery.validate.js and jquery.validate.unobtrusive.js) and have not disabled client side validation, then you will get both client side and server side validation using the validation attributes. This is an excellent feature of MVC so don't ignore it.

user3559349 Over a year ago

Next, @Html.LabelFor(model => model.email) will generate a <label> tag with the text "email", so it would be very confusing to a user if your expecting then to not enter an email (and when they do, display a message telling them its not valid even though it is!). Change the name to something that conveys your meaning, and then add a RegularExpressionAttribute - e.g. [RegularExpression(@"^[a-zA-Z]+$", ErrorMessage = "Only upper and lower case letters are allowed.")]

Edward N · Accepted Answer · 2015-05-07 02:16:24Z

0

The allvalidate() function should look like this ( call submit function, not return value) :

<script>
        function allvalidate() {
            var validated = true;
            if (!validate()) validated = false;
            if (!checkAge(age)) validated = false;
            if (!checkuser(email)) validated = false;

            if(validated)
                $('[type="submit"]').submit();
        }
   </script>

answered May 7, 2015 at 2:16

Edward N

9976 silver badges11 bronze badges

1 Comment

user4833581 Over a year ago

thanks , but in this case it still send the data to server it show an error masseges and blink quickily and save the data to database too , and works link that it return true not false as i want if there any cases didn't met in validation to return false and the data still in client and not to be sent @trungtin1710

Collectives™ on Stack Overflow

form validation in asp.net mvc ( using javascript )

2 Answers 2

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related