Cannot convert Array into String (Ruby)

Question

I'm having trouble with this code (again). I'm trying to get Ruby to check if tree is equal to any of the items in $do_not_scan and all I'm getting is a "cannot convert Array into String" error. Any way to fix such a thing?

My code:

#filesniffer by Touka, ©2015
$filecount = 0
$trees = Dir.entries("C:\\")
$do_not_scan = ["bootmgr", "BOOTNXT", "USER", ".", "Documents and Settings", "PerfLogs", "System Recovery", "System Volume Information", "$RECYCLE.BIN"]
def scan
    $trees.each do |tree|
        unless tree.include?($do_not_scan[0...8])
            puts "scanning #{tree}"
            entries = Dir.entries("c:\\#{tree}")
            entries.each do |filename|
                if filename == "**\*.dll"
                    puts "Found #{filename} in #{tree}"
                end
            end
        end
    end
end
def scan_loop
    $trees.each do |tree|
        scan
        unless tree.include?($do_not_scan[0...8])
            subtrees = Dir.entries("#{tree}")
            subtrees.each do |tree|
                scan
                scan_loop
            end
        end
    end
end
scan_loop
sleep

I would use a Regexp instead. It would help me avoid the issue of case-sensitive comparison of folder names. Also, I would avoid recursion, it uses more resources and there is no need for it in this case. — Myst
– Myst, Commented May 4, 2015 at 13:48
you are also calling scan without updating $trees. You could get rid of the global variable $trees all together by passing it as an argument to the #scan and #scan_loop methods — user2536065
– user2536065, Commented May 4, 2015 at 14:21
side note - please stop using $global variables. They just aren't used in ruby. Normal variables do not need a $ — DGM
– DGM, Commented May 4, 2015 at 14:40
"They just aren't used in ruby." Yes they are, just not very often in normal code and they're a hint that someone doesn't know what they're doing if overused/abused, as in this case. In this case they're an indicator that the OP doesn't understand variable scoping. — the Tin Man
– the Tin Man, Commented May 4, 2015 at 18:00
Why try to reinvent a very well tested and prewritten wheel? Ruby comes with the Find class that will do a recursive descent of a directory hierarchy. Use it instead of trying to do it yourself. Or investigate using Dir.glob('**/*.dll') as it's an alternate path. — the Tin Man
– the Tin Man, Commented May 4, 2015 at 18:03

the Tin Man · Accepted Answer · 2015-05-04 18:01:43Z

1

It looks like the following have to change in the scan and scan_loop methods:

$do_not_scan[0...8].include?(tree)

In place off:

tree.include?($do_not_scan[0...8])

edited May 4, 2015 at 18:01

the Tin Man

161k44 gold badges222 silver badges308 bronze badges

answered May 4, 2015 at 12:22

jon snow

3,0621 gold badge21 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Touka Over a year ago

it's a step in the right direction but it's trying to scan files now. (need to head to class so I'll check back later)

Collectives™ on Stack Overflow

Cannot convert Array into String (Ruby)

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related