Adding arraylist to custom listview

Question

I have made a custom ListView. I'm trying to populate the ListView by Arraylist. I can successfully send data as a string to populate the ListView but not as ArrayList. Only single row with all the values of arraylist is being displayed.

MainActivity

public class MainActivity extends Activity {
ArrayList<Product> products = new ArrayList<Product>();
Adapter listviewAdapter;
List arrlist = new ArrayList();  
  public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    arrlist.add("1");
    arrlist.add("2");

    fillData();   
    listviewAdapter = new Adapter(this, products);
    ListView lvMain = (ListView) findViewById(R.id.lvMain);
    lvMain.setAdapter(listviewAdapter);
  }
  void fillData() {
      products.add(new Product(arrlist.toString(),false)); //problem is here i suppose

  }
}

Adapter.java

public class Adapter extends BaseAdapter {
Context ctx;
LayoutInflater lInflater;
ArrayList<Product> objects;
Adapter(Context context, ArrayList<Product> products) {
    ctx = context;
    objects = products;
    lInflater = (LayoutInflater) ctx
            .getSystemService(Context.LAYOUT_INFLATER_SERVICE);
}
@Override
public int getCount() {
    return objects.size();
}
@Override
public Object getItem(int position) {
    return objects.get(position);
}
@Override
public long getItemId(int position) {
    return position;
}
@Override
public View getView(int position, View convertView, ViewGroup parent) {
    View view = convertView;
    if (view == null) {
        view = lInflater.inflate(R.layout.item, parent, false);
    }
    Product p = getProduct(position);

    ((TextView) view.findViewById(R.id.tvDescr)).setText(p.name);
    CheckBox cbBuy = (CheckBox) view.findViewById(R.id.cbBox);
    return view;
}
Product getProduct(int position) {
    return ((Product) getItem(position));
}
}

Product.java

public class Product {
String name;
boolean selected;

  Product( String items, boolean _box) {
      name = items;
      selected = _box;
  }
}

You passed all arrlist.toString() wooooooo! check your Argument of Product class then..... — M D
– M D, Commented May 4, 2015 at 11:01
removed .toString(); from arrlist.toString() and made changes to Product class i.e List name; boolean selected; Product( List items, boolean _box) { name = items; selected = _box; } Still doesnt solves it — Ted
– Ted, Commented May 4, 2015 at 11:07

Hareshkumar Chhelana · Accepted Answer · 2015-05-04 11:12:27Z

2

Try add each ArrayList item to Product object through iterating ArrayList :

for(String row :arrlist) {
    products.add(new Product(row, false));
}

Define arrlist as String ArrayList instead of generic type List:

ArrayList<String> arrlist = new ArrayList<String>();

edited May 4, 2015 at 11:12

answered May 4, 2015 at 11:04

Hareshkumar Chhelana

24.9k5 gold badges60 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ted Over a year ago

Won't be a type mismatch? From object to string?

Hareshkumar Chhelana Over a year ago

@Ted,Glad to help you.

vishalk · Accepted Answer · 2015-05-04 11:04:24Z

1

Your function should be

void fillData() {
  products.add(new Product("1",false));
  products.add(new Product("2",false));
  products.add(new Product("3",false));
}

answered May 4, 2015 at 11:04

vishalk

6691 gold badge4 silver badges12 bronze badges

1 Comment

Ted Over a year ago

I know sending string works. This works. But my question is sending arraylist containing previous data

Collectives™ on Stack Overflow

Adding arraylist to custom listview

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related